Fix OpenAPI review issues#292
Merged
Merged
Conversation
…ic curl URLs, pin Redoc CDN - Replace absolute server URLs with relative /api/v1 - Fix OptionField.default: nullable:true → type: ['string','null'] (OAS 3.1) - Fix Conversion.result_file: nullable:true + $ref → anyOf (OAS 3.1) - Replace hardcoded https://example.com curl URLs with url() helper - Pin Redoc CDN from /latest/ to /2.x/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all valid findings from inline code review:
https://example.com/api/v1andhttp://localhost/api/v1with/api/v1so generated clients point at the hosting appnullable: trueis removed in OpenAPI 3.1; fixOptionField.default→type: ['string','null']andConversion.result_file→anyOf: [$ref File, type null]https://example.com/api/v1/...with{{ url('/api/v1/...') }}across all 6 curl examples/latest/to/2.x/to avoid silent breakage on major version releasesSkipped nitpick:
@throwsdocblock onopenApiSpec()— test helpers intentionally let exceptions bubble; no documentation value.Test plan
composer testpasses (620 tests)composer lintpassesnpm run buildpassesnullablekeyword remains in openapi.yaml🤖 Generated with Claude Code
Summary by cubic
Aligns the OpenAPI spec and docs with OAS 3.1 and the current host. Fixes client generation issues and prevents breakage in example commands and docs rendering.
/api/v1so generated clients target the hosting app.nullablewith OAS 3.1 unions:OptionField.default→type: ['string','null']Conversion.result_file→anyOf: [File, null]{{ url('/api/v1/...') }}instead of hardcodedhttps://example.com./latest/to/2.x/to avoid breaking changes on major releases.Written for commit 60efa04. Summary will update on new commits.