Skip to content

CONV-317: Document converters index endpoint#278

Merged
menvil merged 1 commit into
developfrom
feature/CONV-317-document-converters-index-endpoint
Jun 3, 2026
Merged

CONV-317: Document converters index endpoint#278
menvil merged 1 commit into
developfrom
feature/CONV-317-document-converters-index-endpoint

Conversation

@menvil

@menvil menvil commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds GET /converters path to OpenAPI spec with Converter schema
  • Adds tests/Feature/Docs/OpenApiPathsTest.php with path assertions
  • Also lays the full OpenAPI path/schema foundation (all 9 Phase 19 endpoints, all required schemas) to support CONV-318–325 incrementally

Test plan

  • Test written first — fails before path added
  • composer test passes (606 tests)

🤖 Generated with Claude Code


Summary by cubic

Adds GET /converters to the OpenAPI spec with a clear Converter schema and a test, fulfilling CONV-317. Also scaffolds Phase 19 paths and shared schemas to unblock CONV-318–CONV-325.

  • New Features
    • Documented GET /converters with 200 and 401 responses returning data: Converter[].
    • Added Phase 19 path scaffolding: /converters/{source}/{target}/schema, /files (upload), /files/{file}/targets, /conversions (estimate, create, status, download), and /credits/balance, plus shared schemas (converters, files, conversions, credits).
    • Added tests/Feature/Docs/OpenApiPathsTest.php to assert the converters index path exists.

Written for commit 71b37bc. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit b40d05f into develop Jun 3, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0c7d79ca-7152-43a6-9093-f606aa69ca1f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-317-document-converters-index-endpoint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-317-document-converters-index-endpoint branch June 3, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant