Skip to content

CONV-261: Test credit pack checkout creation#230

Merged
menvil merged 1 commit into
developfrom
feature/CONV-261-test-credit-pack-checkout-creation
Jun 2, 2026
Merged

CONV-261: Test credit pack checkout creation#230
menvil merged 1 commit into
developfrom
feature/CONV-261-test-credit-pack-checkout-creation

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds failing tests for BillingPaymentService::createCreditPackCheckout()
  • Tests verify: checkout creation returns CheckoutSessionDto, null stripePriceId throws InvalidArgumentException
  • Tests use FakeSubscriptionCheckoutGateway (no real Stripe calls)
  • Tests fail with "Call to undefined method" — intentional, implementation comes in CONV-262

Test plan

  • Tests confirmed failing before implementation
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Adds failing tests for credit pack checkout creation per CONV-261. Tests cover the happy path and null stripePriceId error for BillingPaymentService::createCreditPackCheckout() using a fake checkout gateway (no real Stripe calls).

Written for commit 42a82c6. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5ec0f2b4-9e0c-40b0-9e68-371eafade9f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-261-test-credit-pack-checkout-creation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil force-pushed the feature/CONV-261-test-credit-pack-checkout-creation branch from 6704969 to 42a82c6 Compare June 2, 2026 18:30
@menvil menvil merged commit 1efad5f into develop Jun 2, 2026
1 check was pending
@menvil menvil deleted the feature/CONV-261-test-credit-pack-checkout-creation branch June 2, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant