Skip to content

CONV-235: Add insufficient credits UI state#204

Merged
menvil merged 1 commit into
developfrom
feature/CONV-235-add-insufficient-credits-ui-state
Jun 2, 2026
Merged

CONV-235: Add insufficient credits UI state#204
menvil merged 1 commit into
developfrom
feature/CONV-235-add-insufficient-credits-ui-state

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds 'Not enough credits' error block in the convert step when credits are insufficient
  • Fixes all remaining ProcessConversionJob::handle() calls to pass the new CreditLedger argument
  • Fixes lint issues across Phase 15 files

Test plan

  • DashboardConverterCostTest passes (3 tests: shows 2 credits, shows 1 credit, insufficient credits blocks job)
  • All 425 tests pass
  • composer lint passes
  • npm run build passes

🤖 Generated with Claude Code


Summary by cubic

Adds an insufficient credits UI in the convert step and blocks job creation when the balance can’t cover the estimated cost. Addresses CONV-235 by clearly signaling the issue and preventing failed conversions.

  • New Features

    • Show an inline “Not enough credits” error in the convert step with a helpful message.
    • Prevent creating and queueing conversion jobs when credits are below the estimated cost.
  • Bug Fixes

    • Pass CreditLedger to all ProcessConversionJob::handle() calls to align with the new signature.
    • Minor lint/import cleanups and test updates for consistent assertions.

Written for commit b969ca1. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 9d5f474 into develop Jun 2, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 997332c5-a51f-490c-860e-9403b0c45a19

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-235-add-insufficient-credits-ui-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-235-add-insufficient-credits-ui-state branch June 2, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant