Skip to content

CONV-233: Test failed conversion does not spend credits#202

Merged
menvil merged 1 commit into
developfrom
feature/CONV-233-test-failed-conversion-does-not-spend-credits
Jun 2, 2026
Merged

CONV-233: Test failed conversion does not spend credits#202
menvil merged 1 commit into
developfrom
feature/CONV-233-test-failed-conversion-does-not-spend-credits

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds test verifying failed conversions do not spend credits and charge status becomes failed
  • Uses FakeConverterDriver with shouldFail: true to trigger failure path

Test plan

  • ProcessConversionJobCreditTest passes (2 tests total)

🤖 Generated with Claude Code


Summary by cubic

Add a feature test to ensure failed conversions do not spend credits and set the credit charge to Failed with a captured_amount of 0. Uses a failing FakeConverterDriver and runs ProcessConversionJob end-to-end, addressing CONV-233.

Written for commit 9f0ffc3. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit fda6150 into develop Jun 2, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: abd0fcf6-28eb-4f44-9b92-cf704cd7ee2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-233-test-failed-conversion-does-not-spend-credits

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-233-test-failed-conversion-does-not-spend-credits branch June 2, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant