Skip to content

CONV-232: Capture credits on successful conversion#201

Merged
menvil merged 1 commit into
developfrom
feature/CONV-232-capture-credits-on-successful-conversion
Jun 2, 2026
Merged

CONV-232: Capture credits on successful conversion#201
menvil merged 1 commit into
developfrom
feature/CONV-232-capture-credits-on-successful-conversion

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • ProcessConversionJob now spends credits and marks charge as captured after successful conversion
  • Failed conversions mark the charge as failed without spending credits
  • Uses DB transaction for atomic credit spend + charge update

Test plan

  • ProcessConversionJobCreditTest passes (1 test: balance decrements, charge captured)
  • ProcessConversionJobTest still passes (3 tests, no regression)

🤖 Generated with Claude Code


Summary by cubic

Implements CONV-232 by capturing credits after a successful conversion and marking the charge as captured. On failure, marks the charge as failed without spending credits; credit spend and charge update run atomically in a DB transaction.

Written for commit e26372f. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit f5befa1 into develop Jun 2, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b6d3a0d4-d2b7-4d01-824f-a47e800068e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-232-capture-credits-on-successful-conversion

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-232-capture-credits-on-successful-conversion branch June 2, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant