Skip to content

CONV-231: Test credits captured after successful conversion#200

Merged
menvil merged 1 commit into
developfrom
feature/CONV-231-test-credits-captured-after-successful-conversion
Jun 2, 2026
Merged

CONV-231: Test credits captured after successful conversion#200
menvil merged 1 commit into
developfrom
feature/CONV-231-test-credits-captured-after-successful-conversion

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds test for credit capture after successful conversion (balance decrements, charge status becomes captured)
  • Adds creditCharge HasOne relationship to ConversionJob
  • Adds pngToJpg() factory state to ConversionJobFactory

Test plan

  • Test exists and fails as expected before implementation

🤖 Generated with Claude Code


Summary by cubic

Adds a feature test to ensure credits are captured after a successful conversion. Satisfies CONV-231 by covering balance decrement and captured charge status.

  • New Features
    • Added creditCharge() HasOne on ConversionJob for charge access.
    • Added pngToJpg() state on ConversionJobFactory.
    • New test ProcessConversionJobCreditTest.php using FakeConverterDriver and ConverterDriverRegistry.

Written for commit 09c04ca. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit c6c3224 into develop Jun 2, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7e2665b5-0339-4ae4-ac9b-a87c356fdf00

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-231-test-credits-captured-after-successful-conversion

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-231-test-credits-captured-after-successful-conversion branch June 2, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant