Skip to content

CONV-229: Test conversion job checks credits before queue#198

Merged
menvil merged 1 commit into
developfrom
feature/CONV-229-test-conversion-job-checks-credits-before-queue
Jun 2, 2026
Merged

CONV-229: Test conversion job checks credits before queue#198
menvil merged 1 commit into
developfrom
feature/CONV-229-test-conversion-job-checks-credits-before-queue

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds tests verifying credits are checked before job creation and queue dispatch
  • Tests for: insufficient credits blocks creation, no queue dispatch when blocked, enough credits creates job

Test plan

  • Tests exist and fail as expected before implementation

🤖 Generated with Claude Code


Summary by cubic

Add feature tests to ensure conversion jobs verify user credits before creating the job or dispatching to the queue. Aligns with CONV-229: blocks job creation/dispatch when credits are insufficient; allows creation and dispatch when credits are sufficient.

Written for commit 1717d07. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 7818b80 into develop Jun 2, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1282bc8f-8054-4b85-b0a9-5d01eb5f6bb1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-229-test-conversion-job-checks-credits-before-queue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-229-test-conversion-job-checks-credits-before-queue branch June 2, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant