Skip to content

CONV-226: Test unsupported cost estimation is rejected#195

Merged
menvil merged 1 commit into
developfrom
feature/CONV-226-test-unsupported-cost-estimation-is-rejected
Jun 2, 2026
Merged

CONV-226: Test unsupported cost estimation is rejected#195
menvil merged 1 commit into
developfrom
feature/CONV-226-test-unsupported-cost-estimation-is-rejected

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds test that unknown conversion pairs throw UnsupportedConversionCostException
  • Adds FakeUnsupportedConverter helper for testing unsupported pairs

Test plan

  • ConversionCostEstimatorTest passes (7 tests total)

🤖 Generated with Claude Code


Summary by cubic

Adds a unit test to ensure unsupported conversion pairs are rejected by the cost estimator, throwing UnsupportedConversionCostException (CONV-226). Introduces a FakeUnsupportedConverter helper to simulate unsupported pairs.

Written for commit f877c5b. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a12677ac-0867-4f35-99e4-aa7667d8e03c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-226-test-unsupported-cost-estimation-is-rejected

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 14f6e2b into develop Jun 2, 2026
2 checks passed
@menvil menvil deleted the feature/CONV-226-test-unsupported-cost-estimation-is-rejected branch June 2, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant