Skip to content

CONV-225: Implement cost breakdown#194

Merged
menvil merged 1 commit into
developfrom
feature/CONV-225-implement-cost-breakdown
Jun 2, 2026
Merged

CONV-225: Implement cost breakdown#194
menvil merged 1 commit into
developfrom
feature/CONV-225-implement-cost-breakdown

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Refactors ConfigDrivenConversionCostEstimator::makeCost() to use CreditCostBreakdown DTO
  • Breakdown now uses typed DTO with toArray() serialization instead of plain array

Test plan

  • ConversionCostEstimatorTest passes (6 tests total)

🤖 Generated with Claude Code


Summary by cubic

Implements a typed conversion cost breakdown (CONV-225) by refactoring ConfigDrivenConversionCostEstimator::makeCost() to use CreditCostBreakdown. Behavior is unchanged, but the breakdown is now structured and serialized via toArray() for future extensions.

Written for commit 2f51528. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 8a84417 into develop Jun 2, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 39da0e8e-75cb-4e37-8e5d-aa8aa945723c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-225-implement-cost-breakdown

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-225-implement-cost-breakdown branch June 2, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant