Skip to content

CONV-179: Add table authorization tests#179

Merged
menvil merged 1 commit into
developfrom
feature/CONV-179-add-table-authorization-tests
Jun 2, 2026
Merged

CONV-179: Add table authorization tests#179
menvil merged 1 commit into
developfrom
feature/CONV-179-add-table-authorization-tests

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds RecentConversionsTableAuthorizationTest.php verifying:
    • Other users' conversions are not rendered (file names hidden)
    • Query total is always scoped to current user
    • Download links only appear for own jobs, never for other users' jobs
  • All tests pass immediately (implementation was already correctly scoped)

Test plan

  • does not render another users conversions
  • query is always scoped to the authenticated user
  • download action links to own conversion only
  • composer test passes (325 tests)
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Add authorization tests for RecentConversionsTable to ensure users only see their own conversions, queries are scoped to the authenticated user, and download links appear only for the user's completed jobs. Aligns with CONV-179 by validating the table’s authorization boundaries; no implementation changes required.

Written for commit 005d419. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit d001553 into develop Jun 2, 2026
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ded5f2f6-8bfd-43af-9713-88f7f8599de7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-179-add-table-authorization-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-179-add-table-authorization-tests branch June 2, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant