Skip to content

CONV-177: Add star conversion test#177

Merged
menvil merged 1 commit into
developfrom
feature/CONV-177-add-star-conversion-test
Jun 2, 2026
Merged

CONV-177: Add star conversion test#177
menvil merged 1 commit into
developfrom
feature/CONV-177-add-star-conversion-test

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds two failing tests to RecentConversionsTableActionsTest.php:
    • own conversion can be starred (toggleStar sets is_starred=true)
    • another user's conversion cannot be starred (security)
  • Tests fail with "no column named is_starred" — expected before migration

Test plan

  • Tests written and failing as expected (missing column)
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Adds tests for starring conversions in RecentConversionsTable: owners can toggle star; non-owners cannot. Tests intentionally fail with “no column named is_starred,” matching Linear CONV-177’s pre-migration state.

  • Migration
    • Add the is_starred column before these tests will pass.

Written for commit 1705f1d. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit f741236 into develop Jun 2, 2026
@menvil menvil deleted the feature/CONV-177-add-star-conversion-test branch June 2, 2026 07:44
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 70613f19-abb7-417c-bfe0-90e951a38c19

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-177-add-star-conversion-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant