Skip to content

CONV-175: Add convert again test#175

Merged
menvil merged 1 commit into
developfrom
feature/CONV-175-add-convert-again-test
Jun 2, 2026
Merged

CONV-175: Add convert again test#175
menvil merged 1 commit into
developfrom
feature/CONV-175-add-convert-again-test

Conversation

@menvil

@menvil menvil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds RecentConversionsTableActionsTest.php with two failing tests:
    • own conversion dispatches conversion-repeat-requested event
    • another user's conversion does NOT dispatch the event (security)
  • Tests fail expectedly (method convertAgain not yet implemented)

Test plan

  • Tests written and failing as expected
  • composer lint passes

🤖 Generated with Claude Code


Summary by cubic

Adds failing feature tests for the “convert again” action in RecentConversionsTable to define expected behavior and security. Dispatches conversion-repeat-requested for the owner’s completed job and does not dispatch for jobs owned by others, aligning with CONV-175.

Written for commit ff27840. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit b7f180e into develop Jun 2, 2026
@menvil menvil deleted the feature/CONV-175-add-convert-again-test branch June 2, 2026 07:43
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 034fd49a-28aa-4e72-8dc9-fc90d7cb1f10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-175-add-convert-again-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant