Skip to content

CONV-155: Implement completed state UI#153

Merged
menvil merged 1 commit into
developfrom
feature/CONV-155-implement-completed-state-ui
Jun 1, 2026
Merged

CONV-155: Implement completed state UI#153
menvil merged 1 commit into
developfrom
feature/CONV-155-implement-completed-state-ui

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner
  • Completed state block: Done message, result filename, Download link, Change settings, Convert another
  • Adds convertAnother() and convertWithDifferentSettings() to DashboardConverter
  • Registers conversions.download route with DownloadConversionResultController stub (full security in CONV-159)
  • 275/275 tests pass

🤖 Generated with Claude Code


Summary by cubic

Implements the completed state UI in the dashboard converter with Download, Change settings, and Convert another actions. Connects the flow to a guarded download endpoint to let users fetch their converted file. Addresses CONV-155.

  • New Features
    • Completed state block shows success message, result filename, and actions.
    • Added convertAnother() and convertWithDifferentSettings() to reset to upload or settings.
    • New conversions.download route with DownloadConversionResultController: checks ownership, completed status, file presence/expiry, and storage existence; streams the file with the correct MIME type.

Written for commit b13154d. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 65cf1db into develop Jun 1, 2026
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9f18c48f-648e-4baf-ba93-740df30e4892

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-155-implement-completed-state-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-155-implement-completed-state-ui branch June 1, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant