Skip to content

CONV-149: Add duplicate convert protection#147

Merged
menvil merged 1 commit into
developfrom
feature/CONV-149-add-duplicate-convert-protection
Jun 1, 2026
Merged

CONV-149: Add duplicate convert protection#147
menvil merged 1 commit into
developfrom
feature/CONV-149-add-duplicate-convert-protection

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner
  • Guard in convert(): returns early if step=converting or currentConversionJobId is set
  • Convert Now button added to step=convert in Blade with wire:loading.attr=disabled
  • Test: double convert() call creates only 1 ConversionJob

🤖 Generated with Claude Code


Summary by cubic

Prevent duplicate conversions by guarding convert() and disabling the Convert Now button while starting. Aligns with CONV-149 to ensure only one ConversionJob is created per action.

  • Bug Fixes
    • Added early return in convert() when $step === 'converting' or currentConversionJobId is set.
    • Added "Convert Now" button for the convert step with wire:loading.attr="disabled" and :disabled="$step === 'converting'"; shows “Starting…” while loading.
    • Added a feature test to verify repeated convert calls create only one ConversionJob.

Written for commit a2678a7. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit 2b4596f into develop Jun 1, 2026
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 721c4fc6-e808-496b-8a24-0cdd5e5a5a49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-149-add-duplicate-convert-protection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-149-add-duplicate-convert-protection branch June 1, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant