Skip to content

CONV-147: Add convert button test#145

Merged
menvil merged 1 commit into
developfrom
feature/CONV-147-add-convert-button-test
Jun 1, 2026
Merged

CONV-147: Add convert button test#145
menvil merged 1 commit into
developfrom
feature/CONV-147-add-convert-button-test

Conversation

@menvil

@menvil menvil commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Failing test: calls convert() and expects step=converting + ConversionJob created. Implemented in CONV-148.

🤖 Generated with Claude Code


Summary by cubic

Add a feature test for the DashboardConverter convert flow to meet CONV-147. The test walks the wizard, then asserts step='converting' and that a ConversionJob is created.

Written for commit 06106a4. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@menvil menvil merged commit c3b18fc into develop Jun 1, 2026
@menvil menvil deleted the feature/CONV-147-add-convert-button-test branch June 1, 2026 20:00
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 49ce7570-c147-440c-b444-945863f14d91

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-147-add-convert-button-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant