Fix toggle focus ring and harden settings smoke test#121
Merged
Conversation
Address Phase 8 review: - Toggle focus ring was on the non-focusable track span; ca-focus-ring keys on the element's own :focus-visible, so it never fired for the hidden peer input. Add a .peer:focus-visible ~ .ca-focus-ring-peer rule and apply it to the track. - Add assertHasNoErrors() to the PNG->PDF smoke test so Livewire failures surface instead of leaving stale UI that lets assertSee/assertDontSee pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 8 review follow-ups
Verified each review finding against current code; fixed the two valid ones, skipped the rest.
Fixed
ca-focus-ringstyles.ca-focus-ring:focus-visibleon the element itself, but it was on the non-focusable track<span>while the focusable checkbox ispeer sr-only— so keyboard focus never showed a ring. Added.peer:focus-visible ~ .ca-focus-ring-peertotheme.cssand appliedca-focus-ring-peerto the track. Confirmed present in the compiled CSS bundle.->assertHasNoErrors()to the PNG→PDF smoke test before the visibility assertions so a Livewire error can't mask stale UI.Skipped
goToFormatStepdoesn't exist" (invalid). The method exists (DashboardConverter::goToFormatStep, line 87) and the navigation tests pass — the comment is stale.composer test (233), lint, build all pass.
🤖 Generated with Claude Code
Summary by cubic
Fixes the toggle focus ring so keyboard users see a visible outline, and hardens the settings smoke test to catch Livewire errors early.
.peer:focus-visible ~ .ca-focus-ring-peerintheme.cssand appliedca-focus-ring-peerto the track so focus is visible on the toggle.->assertHasNoErrors()before visibility checks to surface Livewire failures instead of passing with stale UI.Written for commit f0f3398. Summary will update on new commits.