Skip to content

CONV-108: Validate settings before convert step#116

Merged
menvil merged 1 commit into
developfrom
feature/CONV-108-validate-settings-before-convert-step
May 31, 2026
Merged

CONV-108: Validate settings before convert step#116
menvil merged 1 commit into
developfrom
feature/CONV-108-validate-settings-before-convert-step

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-108 — Validate Settings Before Convert Step

A Continue action validates settings and advances to a placeholder convert step only when options are valid.

  • New continueFromSettings(): guards file/target, runs validateSettings(), advances to convert on success or stays on settings with field errors.
  • Settings step gains a Continue button; new convert placeholder block ("available in Phase 9").
  • Stepper highlight now maps every step (File/Format/Settings/Convert).
  • No ConversionJob / queue / billing.

Tests

  • valid settings → convert step, no errors
  • invalid settings → stay on settings with options.quality error
  • continuing creates no extra records

composer test (227), lint, build pass.

🤖 Generated with Claude Code


Summary by cubic

Validates settings before advancing from Settings to Convert, and adds a Convert placeholder with proper stepper highlighting. Fulfills Linear CONV-108; no conversion jobs or records are created yet.

  • New Features
    • Validate settings on Continue from Settings; move to Convert on success, otherwise stay and show field errors. No new records or jobs are created.
    • UI updates: Continue button on Settings, stepper highlights File/Format/Settings/Convert correctly, and a Convert placeholder with a Back action.

Written for commit 634df2c. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit a6bdfa9 into develop May 31, 2026
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: df7da030-7e00-4e9d-bf06-fb2180a02ce9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-108-validate-settings-before-convert-step

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-108-validate-settings-before-convert-step branch May 31, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant