Skip to content

CONV-107: Add settings field validation errors#115

Merged
menvil merged 1 commit into
developfrom
feature/CONV-107-add-settings-field-validation-errors
May 31, 2026
Merged

CONV-107: Add settings field validation errors#115
menvil merged 1 commit into
developfrom
feature/CONV-107-add-settings-field-validation-errors

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-107 — Add Settings Field Validation Errors

Field-level validation for settings options via the existing OptionsValidator.

  • InvalidConverterOptionsException now carries the offending optionKey and exposes fieldErrors().
  • New validateSettings() on the component maps field errors to options.{key} on the Livewire error bag.
  • The dynamic form renders @error('options.{key}') next to each field (handled once in the partial wrapper, so every renderer benefits).
  • No converter-specific validation in the component; schema is the source of truth.

Tests

  • invalid option → options.quality error
  • default options → no errors
  • unknown option → options.bogus error
  • validation creates no extra records

composer test (224), lint, build pass.

🤖 Generated with Claude Code


Summary by cubic

Adds field-level validation for converter settings and shows inline errors in the dynamic options form. Addresses CONV-107 by mapping OptionsValidator errors to Livewire’s options.{key} and using the schema as the source of truth.

  • New Features
    • InvalidConverterOptionsException now includes optionKey and fieldErrors().
    • Added validateSettings() in DashboardConverter to validate and add errors to options.{key}.
    • The dynamic form renders @error('options.{key}') messages under each field.
    • Tests cover invalid, unknown, and default options; no extra records are created.

Written for commit 866d63e. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit bae75c1 into develop May 31, 2026
@menvil menvil deleted the feature/CONV-107-add-settings-field-validation-errors branch May 31, 2026 17:27
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d74ef4f0-9367-4e6e-a794-e325718e0851

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-107-add-settings-field-validation-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant