Skip to content

CONV-106: Render PNG to PDF settings#114

Merged
menvil merged 1 commit into
developfrom
feature/CONV-106-render-png-to-pdf-settings
May 31, 2026
Merged

CONV-106: Render PNG to PDF settings#114
menvil merged 1 commit into
developfrom
feature/CONV-106-render-png-to-pdf-settings

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-106 — Render PNG To PDF Settings

Verifies the PNG→PDF settings form renders entirely from schema, distinct from PNG→JPG.

  • Page size, Orientation, Margin, Fit mode, Compression all render via the segmented renderer.
  • No PNG/PDF conditionals in Blade; the form differs solely because the converter schema differs.

Tests

  • PNG→PDF renders its five fields and does not show Background color (a JPG-only field)

composer test (220), lint, build pass.

🤖 Generated with Claude Code


Summary by cubic

Add a feature test for PNG→PDF settings (CONV-106) to ensure the form renders from the converter schema and differs from PNG→JPG. Verifies the five expected fields (Page size, Orientation, Margin, Fit mode, Compression) are shown and that the JPG-only “Background color” is not.

Written for commit 9612d15. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit 6a81eba into develop May 31, 2026
@menvil menvil deleted the feature/CONV-106-render-png-to-pdf-settings branch May 31, 2026 17:25
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: effcd9d1-c738-4cff-8b97-239de33d2930

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-106-render-png-to-pdf-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant