Skip to content

CONV-104: Initialize default converter options#112

Merged
menvil merged 1 commit into
developfrom
feature/CONV-104-initialize-default-converter-options
May 31, 2026
Merged

CONV-104: Initialize default converter options#112
menvil merged 1 commit into
developfrom
feature/CONV-104-initialize-default-converter-options

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-104 — Initialize Default Converter Options

After loading the schema, $options is seeded from each field's default.

  • New initializeOptionsFromSchema(); fields without a default are skipped.
  • Switching target resets $options to the new schema's defaults (no leakage of incompatible options).

Tests

  • defaults copied from PNG→JPG schema
  • switching JPG→PDF resets options to PDF defaults

composer test (218), lint, build pass.

🤖 Generated with Claude Code


Summary by cubic

Initialize converter options from the selected schema’s defaults and reset them on target changes to avoid stale or incompatible values. Implements CONV-104.

  • New Features
    • Added initializeOptionsFromSchema() to seed $options from $optionsSchema defaults (skips fields without a default or key).
    • Called during selectTargetFormat, so switching targets resets options to the new schema’s defaults.

Written for commit a012a59. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit e320293 into develop May 31, 2026
@menvil menvil deleted the feature/CONV-104-initialize-default-converter-options branch May 31, 2026 17:23
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f88088aa-e56f-461f-91b6-899553ab3252

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-104-initialize-default-converter-options

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant