Skip to content

CONV-103: Load converter options schema on target selection#111

Merged
menvil merged 1 commit into
developfrom
feature/CONV-103-load-converter-options-schema-on-target-selection
May 31, 2026
Merged

CONV-103: Load converter options schema on target selection#111
menvil merged 1 commit into
developfrom
feature/CONV-103-load-converter-options-schema-on-target-selection

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-103 — Load Converter Options Schema On Target Selection

selectTargetFormat now resolves the converter and loads its optionsSchema() into component state.

  • New selectedConverterKey state; optionsSchema populated from the converter.
  • Unsupported target fully resets target selection (key + schema + options cleared).
  • No ConversionJob created.

Tests

  • selecting a target loads schema + key and renders schema fields (Quality, Background color)
  • unsupported target clears the loaded schema/key

composer test (216), lint, build pass.

🤖 Generated with Claude Code


Summary by cubic

CONV-103: Load converter options schema when a target format is selected. Users go straight to Settings; unsupported targets fully reset selection and show a clear error.

  • New Features
    • Resolve converter on selection and set selectedTargetFormat, selectedConverterKey, and optionsSchema.
    • Step switches to 'settings' after schema loads; no ConversionJob is created.
    • Unsupported targets call resetTargetSelection() to clear key, schema, and options, and return to 'format'.

Written for commit fba27fe. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit 2037f23 into develop May 31, 2026
@menvil menvil deleted the feature/CONV-103-load-converter-options-schema-on-target-selection branch May 31, 2026 17:23
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1c58d9b2-4ae6-4509-a019-5b6f67b9fa22

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-103-load-converter-options-schema-on-target-selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant