Skip to content

CONV-098: Add segmented field renderer#106

Merged
menvil merged 1 commit into
developfrom
feature/CONV-098-add-segmented-field-renderer
May 31, 2026
Merged

CONV-098: Add segmented field renderer#106
menvil merged 1 commit into
developfrom
feature/CONV-098-add-segmented-field-renderer

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-098 — Add Segmented Field Renderer

Per-type renderer for segmented fields.

  • Renders label, optional help text, and all choices.
  • Active choice is visually distinct and exposes aria-pressed.
  • Clicking a choice sets options.{key} via $set.

Tests

  • segmented field renders label + all choices + active state
  • bound option updates on change

composer test (209), lint, build pass.

🤖 Generated with Claude Code


Summary by cubic

Adds a per-type renderer for segmented settings fields in the dashboard converter. Addresses CONV-098 by rendering label/help, showing all choices, and syncing selection to options.{key}.

  • New Features
    • Renders label and optional help text.
    • Displays all choices; active choice is styled and sets aria-pressed.
    • Clicking a choice updates options.{key} via $set.

Written for commit 2e013c0. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit 584521a into develop May 31, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f6b0e1e0-4427-41be-a192-7605c89d31a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-098-add-segmented-field-renderer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-098-add-segmented-field-renderer branch May 31, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant