CONV-097: Create dynamic options form partial#105
Merged
menvil merged 1 commit intoMay 31, 2026
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONV-097 — Create Dynamic Options Form Partial
Adds the schema-driven
dynamic-options-formpartial wired into the settings step.optionsSchema/optionspublic state onDashboardConverter.$optionsSchemaand delegates each field to a per-type renderer underfields/<type>.blade.php.Note: the real converter
optionsSchema()is a list of fields each carrying akey, so the partial iterates the list (not an associative map).Tests
composer test (207), lint, build all pass.
🤖 Generated with Claude Code
Summary by cubic
Implements CONV-097 by adding a schema-driven dynamic options form to the converter settings step. It renders fields by type and shows a clear fallback for unknown types.
dynamic-options-formpartial and included it in the settings step.optionsSchema(list of field configs) andoptionsonDashboardConverter.fields/<type>.blade.phpwith no source/target conditionals.Written for commit 9c07f3d. Summary will update on new commits.