Skip to content

CONV-097: Create dynamic options form partial#105

Merged
menvil merged 1 commit into
developfrom
feature/CONV-097-create-dynamic-options-form-partial
May 31, 2026
Merged

CONV-097: Create dynamic options form partial#105
menvil merged 1 commit into
developfrom
feature/CONV-097-create-dynamic-options-form-partial

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-097 — Create Dynamic Options Form Partial

Adds the schema-driven dynamic-options-form partial wired into the settings step.

  • New optionsSchema / options public state on DashboardConverter.
  • Partial iterates $optionsSchema and delegates each field to a per-type renderer under fields/<type>.blade.php.
  • Unknown field types render a controlled "Unsupported field type: …" fallback instead of silently disappearing.
  • No converter-specific (source/target) conditionals in Blade.
  • The Phase 7 placeholder is retained for now; it is replaced by the real form in CONV-105.

Note: the real converter optionsSchema() is a list of fields each carrying a key, so the partial iterates the list (not an associative map).

Tests

  • dynamic form container + per-field wrapper render on settings step
  • unsupported field type renders controlled fallback

composer test (207), lint, build all pass.

🤖 Generated with Claude Code


Summary by cubic

Implements CONV-097 by adding a schema-driven dynamic options form to the converter settings step. It renders fields by type and shows a clear fallback for unknown types.

  • New Features
    • Added dynamic-options-form partial and included it in the settings step.
    • Exposed optionsSchema (list of field configs) and options on DashboardConverter.
    • Delegated each field to fields/<type>.blade.php with no source/target conditionals.
    • Tests verify the form container renders and the unsupported type fallback appears.

Written for commit 9c07f3d. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit 0be3d78 into develop May 31, 2026
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 743c9bbf-f6f0-4e34-bd3e-b7fa3024ec06

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-097-create-dynamic-options-form-partial

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-097-create-dynamic-options-form-partial branch May 31, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant