Skip to content

CONV-096: Add settings step guard#104

Merged
menvil merged 1 commit into
developfrom
feature/CONV-096-add-settings-step-guard
May 31, 2026
Merged

CONV-096: Add settings step guard#104
menvil merged 1 commit into
developfrom
feature/CONV-096-add-settings-step-guard

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-096 — Add Settings Step Guard

Guards the settings step so it cannot be reached without an uploaded file and a selected target format.

  • Extend ensureValidStep() to also cover the settings step (missing file → upload, missing target → format).
  • Add goToSettingsStep() with the same guard semantics.

Tests

tests/Feature/Livewire/DashboardConverterSettingsStepTest.php:

  • settings step without file → upload
  • settings step without selected target → format
  • stale file id → upload
  • file + target present → settings

composer test (205), composer lint, npm run build all pass. No ConversionJob/queue/billing.

🤖 Generated with Claude Code


Summary by cubic

Adds a guard for the converter settings step so it’s only reachable with an uploaded file and a selected target format (CONV-096). Redirects to upload if no file, and to format if no target, preventing invalid navigation.

  • New Features
    • Extend ensureValidStep() to handle settings: missing file → upload, missing target → format.
    • Add goToSettingsStep() with the same checks; clears invalid file ID and resets target when needed.

Written for commit c1a0d83. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@menvil menvil merged commit 77a8344 into develop May 31, 2026
1 check was pending
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 760a11ae-7482-4e54-ba54-588ea93c8f51

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-096-add-settings-step-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil deleted the feature/CONV-096-add-settings-step-guard branch May 31, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant