Skip to content

CONV-095: Add target format step smoke tests#102

Merged
menvil merged 1 commit into
developfrom
feature/CONV-095-add-target-format-step-smoke-tests
May 31, 2026
Merged

CONV-095: Add target format step smoke tests#102
menvil merged 1 commit into
developfrom
feature/CONV-095-add-target-format-step-smoke-tests

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-095 — Add Target Format Step Smoke Tests

Final Phase 7 regression coverage for the upload → format → settings flow.

Tests

  • Full flow: upload PNG → format step shows Convert PNG to + JPG/WEBP/PDF → select JPG → settings placeholder "Settings for PNG to JPG".
  • Target selection persists no extra records (proxy for "no ConversionJob"): FileRecord count stays at 1. No direct ConversionJob test — the model/table does not exist before Phase 9.
  • Full back-and-forth navigation (settings → format → upload summary) preserves the uploaded file.

No new feature code — tests only.

composer test (201), composer lint, npm run build all pass.

🤖 Generated with Claude Code


Summary by cubic

Add smoke tests for the target format step in the Dashboard converter (upload → format → settings), per CONV-095.
Verify PNG upload shows JPG/WEBP/PDF options, selecting a target advances to settings, no extra FileRecord rows are created, and back/forward navigation keeps the uploaded file.

Written for commit 7bf3b5b. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c997ab4-6f97-4f77-b17d-8597186d1e7a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-095-add-target-format-step-smoke-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit 27c70c6 into develop May 31, 2026
1 of 2 checks passed
@menvil menvil deleted the feature/CONV-095-add-target-format-step-smoke-tests branch May 31, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant