Skip to content

CONV-094: Add target format step loading and error states#101

Merged
menvil merged 1 commit into
developfrom
feature/CONV-094-add-target-format-step-loading-and-error-states
May 31, 2026
Merged

CONV-094: Add target format step loading and error states#101
menvil merged 1 commit into
developfrom
feature/CONV-094-add-target-format-step-loading-and-error-states

Conversation

@menvil

@menvil menvil commented May 31, 2026

Copy link
Copy Markdown
Owner

CONV-094 — Add Target Format Step Loading And Error States

Adds tidy loading and error UX to the target-format step.

Changes

  • Unsupported-conversion error now renders as a styled alert (targetFormatError).
  • Added a wire:loading spinner targeting selectTargetFormat ("Loading converter settings…").
  • Target cards are disabled (wire:loading.attr="disabled" + disabled: styles) while a selection is processing.

Tests

  • Invalid target selection shows the full "This conversion is not supported yet." message.
  • Format step renders a loading indicator targeting selectTargetFormat.

composer test (198), composer lint, npm run build all pass.

🤖 Generated with Claude Code


Summary by cubic

Implements CONV-094 by adding clear loading and error states to the target-format step. Users now see a spinner while settings load, cards are disabled during processing, and unsupported conversions show a styled alert.

  • New Features
    • Styled alert for unsupported conversions via targetFormatError.
    • Loading indicator scoped to selectTargetFormat.
    • Disable target cards while selectTargetFormat is processing.

Written for commit ae1eb59. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a62309db-4faa-41e0-a94f-d311f70ad05d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/CONV-094-add-target-format-step-loading-and-error-states

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@menvil menvil merged commit ef51371 into develop May 31, 2026
1 of 2 checks passed
@menvil menvil deleted the feature/CONV-094-add-target-format-step-loading-and-error-states branch May 31, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant