Skip to content

fix(memory): re-raise LLM extraction failures instead of returning [] #5178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thalesfsp wants to merge 1 commit into from
Closed

fix(memory): re-raise LLM extraction failures instead of returning [] #5178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions mem0/memory/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,8 +744,11 @@ def _add_to_vector_store(self, messages, metadata, filters, infer, prompt=None):
response_format={"type": "json_object"},
)
except Exception as e:
# PATCH (openclaw): re-raise so callers can implement provider fallback.
# The original silent ``return []`` makes upstream callers unable to
# distinguish "LLM unavailable" from "LLM extracted no facts".
logger.error(f"LLM extraction failed: {e}")
return []
raise

# Parse response
try:
Expand Down Expand Up @@ -2161,8 +2164,9 @@ async def _add_to_vector_store(
response_format={"type": "json_object"},
)
except Exception as e:
# PATCH (openclaw): re-raise so callers can implement provider fallback.
logger.error(f"LLM extraction failed (async): {e}")
return []
raise

# Parse response
try:
Expand Down