Skip to content

feat(github-actions-conventions): reserve the work function resolve-issue - #788

Merged
kyle-sexton merged 1 commit into
mainfrom
feat/vocab-resolve-issue
Oct 14, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
feat/vocab-resolve-issue

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

No related issue: issue-work lane Phase 1, owner-approved plan 2026-10-14

Hold: a human merges this

Summary

The issue-work lane in claude-code-plugins names its caller workflow work-resolve-issue.yml. The naming lint rejects that file name until the work stage lists the function word resolve-issue. This reserves it before that repo uses it, as run-activity was reserved in #689.

Fix

In components/github-actions-conventions/vocabulary.json, functions.work gains resolve-issue with status reserved and a purpose. It moves to in-use once the workflow is on a main branch. The verb resolve is already listed.

Verification

  • npm run test:github-actions-conventions: 14 pass, 0 fail.
  • npm run lint:github-actions-conventions: 0 findings, 0 blocking.
  • naming-lint.mjs --mode enforcing on a scratch root holding .github/workflows/work-resolve-issue.yml (name: work-resolve-issue): 0 findings. The same file renamed work-resolve-ticket.yml gives a workflow-filename error listing resolve-issue, respond-mention.

Related

After the merge, the standards sync lands the copy in claude-code-plugins (.github/standards/). The broker change is in melodic-software/azure-iac and the token input in melodic-software/claude-code-plugins, both opened alongside this PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CQKJiE8NBix1bgynWFSkqp

…ssue

The issue-work lane in claude-code-plugins names its caller
work-resolve-issue.yml; the naming lint rejects it until the work stage
lists resolve-issue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CQKJiE8NBix1bgynWFSkqp
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T16:55:52.720046Z 3d9eeea Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 5s —— View job


Review: reserve resolve-issue in work stage

  • Gather context (diff, vocabulary.json, vocabulary.schema.json, naming-lint.mjs/tests, README)
  • Check schema conformance and vocabulary conventions
  • Check ordering/consistency against existing reserved entries
  • Post review

Findings: none.

Checked:

  • New entry matches vocabulary.schema.json (name/status/purpose shape, kebab pattern) — schema.
  • resolve-issue is verb-first; resolve is already an accepted verb — verbs list.
  • Placement keeps the work array in the same alphabetical order used by the other stage arrays (resolve-issue < respond-mention), consistent with intake/pr/release/maintenance.
  • Shape matches existing reserved entries with a purpose string (e.g. explain, merge, refine, verify, publish-plugins), and follows the precedent of reserving a word ahead of the workflow that will use it (run-activity in feat(github-actions-conventions): reserve the pr function run-activity #689), per README.md L30-31.
  • No README update needed: the README's generated table only tracks stages, not per-stage function words.

Note: I did not independently run npm run test:github-actions-conventions / lint:github-actions-conventions / naming-lint.mjs in this sandbox (no tool access to execute npm), so the PR description's test/lint results are author-claimed and unverified by me. Manual check against the schema and test file (naming-lint.test.mjs) shows no structural issue that would fail them.
(branch: feat/vocab-resolve-issue)

claude-lane-summary: lane=claude-review sha=3d9eeea1e7344e06bc08fd39a4a0e5adcbb75b6c run=38602064429

@claude

claude Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 26s —— View job


Security review complete

  • Gather context (PR diff, changed files)
  • Review changed file for security-relevant issues
  • Check instruction-surface deletions
  • Post findings / summary

Scope: 1 file changed, components/github-actions-conventions/vocabulary.json (+8/-1) — diff.

Finding: None. The change is a pure data addition to a vocabulary registry — it reserves the function name resolve-issue under the work stage with a status/purpose entry. It contains no executable code, no credentials/tokens, no authorization logic, and no injection surface. It's additive only (no deletion, narrowing, or softening of any standing instruction or guardrail), so the instruction-surface-deletion lens doesn't apply here.

No security issues found.

claude-lane-summary: lane=claude-security-review sha=3d9eeea1e7344e06bc08fd39a4a0e5adcbb75b6c run=38602065069

@github-actions

Copy link
Copy Markdown

claude-security-review has reviewed this pull request through 3d9eeea; a later push is reviewed from there.

@github-actions

Copy link
Copy Markdown

claude-review has reviewed this pull request through 3d9eeea; a later push is reviewed from there.

@kyle-sexton
kyle-sexton merged commit 83cbbe1 into main Oct 14, 2026
39 of 41 checks passed
@kyle-sexton
kyle-sexton deleted the feat/vocab-resolve-issue branch October 14, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant