fix(distribution): absorb consumer deltas the first fleet sync surfaced - #69
Conversation
|
Claude finished @kyle-sexton's task in 1m 47s —— View job PR Review
OverallClean, well-reasoned PR. The two changes are internally consistent, the PR description matches the diff exactly, and the one factual claim I could verify independently checks out. No bugs, no security issues, no architectural concerns.
|
| Token | Risk of cross-repo false-suppress |
|---|---|
abd |
Low — short but exact-case match only |
BAAs |
Negligible — specific enough |
FoD |
Negligible |
PnPCapabilities |
Negligible — very specific |
The claim that "each entry only skips its exact token, so the union is inert outside the repos that need it" holds for identifiers. If domain words (case-insensitive [default.extend-words]) are ever added to the union in the future, that inertness guarantee weakens — worth keeping in mind as the list grows.
Each entry is annotated with its origin repo and use case (lines 33–40), which is exactly the right pattern for a union that will keep growing.
Example comment block removal — intentional and correct. Keeping the old commented-out extend-words/extend-identifiers examples would have been misleading now that local extension is prohibited.
Summary
No changes needed. Both diffs are correct. The minor observations above (external path reference, soft re-add trigger) are informational — not blockers.
The first real sync PRs showed local edits the full-file overwrite would destroy — the exact drift-vs-customization seam Track B has to answer, resolved per file: - typos: the base now carries the constellation-wide union of domain identifiers (provisioning's PnPCapabilities/FoD/BAAs, dotfiles' abd) and documents the new route-upstream policy — typos has no config layering, so local edits cannot survive a verbatim sync (supersedes the copy-adoption-era "adopters add them locally" guidance). - shellcheck: dropped from dotfiles' include — its minimal .shellcheckrc is a documented deliberate divergence (the SSOT's require-double-brackets would flag its statusline's intentional [ ] idiom), tracked as FU4 in the repo itself; sync resumes when FU4 lands. The lychee delta (private-repo excludes) is already upstream as #58. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GbDWhcUtduCejgi7mcbMfy
|
Claude finished @kyle-sexton's task in 1m 28s —— View job
OverallThis is a re-review triggered by the merge of
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83493e78b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # CONSTELLATION-WIDE UNION. This file is synced verbatim to consumers and typos | ||
| # has no config layering, so a repo-specific exception cannot survive as a | ||
| # local edit — route it here via an upstream PR (decided 2026-07-06, | ||
| # superseding the copy-adoption-era "adopters add them locally" guidance). |
There was a problem hiding this comment.
Update typos docs for upstream-only exceptions
This policy change makes _typos.toml the synced union and tells consumers to route repo-specific exceptions upstream, but modules/typos/README.md still says the config ships no domain words and tells adopters to extend it locally (lines 9-12 and 48-50). For any consumer following the module README, that creates exactly the downstream-only edits the sync will overwrite, so the new route-upstream rule won't prevent repeated drift PRs unless the README is updated with the same policy.
Useful? React with 👍 / 👎.
## Summary Closes out the activation checklist record after tonight's completion: App access fully done and verified (selected-repos flip, public App, personal-account installation proven by all four kyle-sexton sync legs minting tokens, local PEM deleted per key-hygiene guidance); both Layer-1 packages published and public (`biome-config@1.0.1` post-#70, `tsconfig@1.0.0`); full-fleet Layer-2 rollout merged across both accounts, with the first fleet pass's consumer customizations routed upstream (#58, #69). Remaining opens, each with an owner: the read-only marking (engine feature) and medley#1243 (Layer-1 pilot, in review). ## Verification markdownlint (module config) + editorconfig-checker clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01GbDWhcUtduCejgi7mcbMfy <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only status changes with no runtime, auth, or deployment impact. > > **Overview** > Updates the **gated activation checklist** in `config-distribution-plan.md` to reflect work completed 2026-07-06/07. > > **GitHub App + access** is marked fully done: org install limited to selected repos (API-verified), App public, personal-account install proven by all four `kyle-sexton` sync legs minting tokens, and the local private key removed after secrets validation. > > **Layer-1** narrative now states both packages are published and public (`biome-config@1.0.1`, `tsconfig@1.0.0`), with the open work narrowed to checking off the parent item when **medley#1243** merges. > > **Layer-2** is recorded as a **full-fleet rollout** across both accounts (not only org targets), including examples of consumer customizations routed upstream on the first pass. The only remaining blocker before closing that item is **read-only marking** (header comments + consumer CODEOWNERS), called out as an engine feature rather than a rollout step. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit c75c611. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>


Summary
The first fleet-wide sync PRs surfaced three local consumer edits that a verbatim overwrite would have destroyed — each resolved at the SSOT per the Track B operating rule (route changes upstream), with the policy recorded where it applies:
modules/typos/_typos.toml): now carries the constellation-wide union of domain identifiers — provisioning'sPnPCapabilities/FoD/BAAs, dotfiles'abd— each annotated. typos has no config layering, so repo-local exceptions cannot coexist with a synced file; the file's own comments now state the route-upstream policy (decided 2026-07-06, superseding the "adopters add them locally" guidance from the copy-adoption era). Each identifier only skips its exact token, so the union is inert elsewhere.kyle-sexton/dotfiles' include list. Its.shellcheckrcis a documented deliberate minimal divergence (the SSOT'srequire-double-brackets— verified enabled — would flag the statusline's intentional[ ]graceful-degradation idiom), with SSOT alignment already tracked as FU4 in that repo. The manifest comment carries the re-add trigger. Notably dotfiles has no CI shellcheck lane, so the overwrite would have broken pre-commit hooks silently.Merging this re-fires the sync cascade (paths match), refreshing the open personal sync PRs so their deletions disappear.
Verification
Manifest parses (yq); typos lane runs in this PR's own CI against the updated config; SSOT
require-double-bracketsclaim verified againstmodules/shellcheck/.shellcheckrc.🤖 Generated with Claude Code
https://claude.ai/code/session_01GbDWhcUtduCejgi7mcbMfy
Note
Low Risk
Config and manifest-only changes for spellcheck and sync scope; no runtime or auth paths, with typos union entries scoped to exact tokens.
Overview
Aligns Track B distribution with what the first fleet sync would have overwritten: typos config and the dotfiles shellcheck target.
typos (
modules/typos/_typos.toml) now documents that the synced file is read-only downstream and holds a constellation-wide union of[default.extend-identifiers](abd,BAAs,FoD,PnPCapabilities), each annotated, replacing the old “adopters extend locally” guidance.kyle-sexton/dotfilesno longer includes shellcheck indistribution/sync-manifest.yml, with a comment that its local.shellcheckrcintentionally diverges (SSOTrequire-double-bracketsvs statusline[ ]idiom, FU4) and should be re-added when that follow-up lands.Reviewed by Cursor Bugbot for commit 83493e7. Bugbot is set up for automated code reviews on this repo. Configure here.