Repository navigation
feat(distribution): sync the github-actions-conventions vocabulary to claude-code-plugins - #688
Conversation
… claude-code-plugins The pr-pipeline config reader in claude-code-plugins checks lane and activity names against vocabulary.json read from the base SHA, so the vocabulary and its schema need to be managed files there. The managed-files-guard path lists gain both destinations so hand edits are caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 53s —— View job Security review —
|
|
Claude finished @kyle-sexton's task in 2m 27s —— View job Code review complete
No findings. This is a narrow, mechanical config change and it's internally consistent:
I wasn't able to execute |
#689) No related issue: naming-lint finding on claude-code-plugins#6263, which adds the PR lane runner. ## Summary claude-code-plugins#6263 adds `.github/workflows/pr-run-activity.yml`, the reusable runner every PR lane calls. The naming lint rejects it because `run-activity` is not a `pr` function word. CI/CD Conventions flagged the unprefixed name, and the stage-first name was then chosen. ## Fix `vocabulary.json` `functions.pr` gains `run-activity`, with status `reserved` and a purpose. It moves to `in-use` once the workflow is on a main branch. ## Verification - `npm run test:github-actions-conventions`: 14 passed, 0 failed. - `naming-lint.mjs --mode enforcing` against the claude-code-plugins branch reports no finding for `pr-run-activity`, `resolve-config` or `report-check-run`. - `biome check` on the file is clean. ## Related - claude-code-plugins#6263 (consumer). The vocabulary syncs there through the entry from #688. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: unblocks the ci-workflows v0.38.0 fleet repin in the GitHub Actions conventions migration. ## Summary Registers the nine ci-workflows reusables at the v0.38.0 tag `95732fda50a95d3297320a6f2c791a1a91870a7f` in `components/runner-policy/policy.json`, so consumer repins from v0.36.0 pass runner-policy. The `fb56986` (v0.36.0) entries stay until every consumer has repinned; a follow-up retires them. ## Fix - `policy.json`: nine new keys, each body a verbatim copy of its `fb56986` entry (text-spliced, no re-serialization; 121 insertions, 0 deletions). - `README.md`: review note for v0.38.0 (identical blobs, `$/` tree changes, zizmor and upload-sarif bumps, the hand sign-off of the four secret-capable entries, and the `maintenance-sync-standards` disarm/re-arm behavior from ci-workflows#688 plus the failed re-arm now failing the run). The v0.36.0 sentence about `fb56986` being the only admitted SHA now reads in the past tense. ## Verification - `git diff fb56986..95732fd -- .github/workflows` in ci-workflows matches the per-reusable review: six reusables changed, three byte-identical; no input, secret, caller permission or `runs-on` routing moved. `maintenance-sync-standards.yml` was re-diffed against the #688 head reviewed (`d564b5bc`): the only addition is a `setFailed` when a run disarms and cannot re-arm. - `npm run test:runner-policy` (297/297), `npm run lint:runner-policy`, `npx biome check components/runner-policy/policy.json`, `npm run lint:md`: all pass. ## Related - ci-workflows v0.38.0 release (`95732fd`) - ci-workflows#688 (sync re-arm behavior) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: Phase 2 of the pr-pipeline config-reader plan in claude-code-plugins; no tracker item exists for it.
Hold: a human merges this.
Summary
claude-code-plugins is building
resolve-config, the pr-pipeline config reader. It checks lane and activity names againstcomponents/github-actions-conventions/vocabulary.json, read from the base SHA. This PR makes the vocabulary and its schema managed files in claude-code-plugins at.github/standards/github-actions-conventions/.Fix
distribution/sync-manifest.yml: a newgithub-actions-conventionscomponent (vocabulary.json,vocabulary.schema.json), added only to claude-code-plugins'managedlist, next totrusted-actors.components/managed-files-guard/managed-files-guard.ymland-fleet.yml: both destination paths added to thepaths:trigger, so the guard catches hand edits to the synced files, as it does for trusted-actors.Verification
bash harness/shell/run-tests.sh components/managed-files-guard/managed-files-guard.test.sh distribution/sync-manifest.test.sh: 2 passed, 0 failed.bash distribution/sync-manifest.sh validate: "Manifest valid: 41 components, 13 targets".Related
🤖 Generated with Claude Code