docs(topics): add the Phase 6 engine-Node-port plan - #452
Conversation
Grounded on a fresh-context exploration of the engine contract and stress-tested by two independent fresh-context reviews (2 CRITICAL and 8 IMPORTANT findings verified and folded in). Adds the Phase 6 decisions (yaml dependency with dev-split and pinned parser config; exec-wrapper entrypoint continuity; staged dual-gate cutover; no-Node control inversion), five sequential sub-phases with mechanically verifiable sanity checks, the HIGH blast-radius entry, the stress-test summary, the execution-shape rows, and the pending user-approval gates. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 3m 26s —— View job Code review — Phase 6 plan addition
This is a docs-only addition to I independently verified several of the plan's grounding claims against
I could not run One finding, on an unchanged line the diff doesn't carry, so it's placed here per the reporting split: Suggestion — stale suite-length figure left uncorrected in the Brief's acceptance criteria Everything else in the addition — the four decision blocks (6-A..6-D), the five sub-phase blocks with Sanity Checks, the blast-radius entry, the stress-test summary, the execution-shape table, and the approval-gate rows — read as internally consistent and well-grounded against current repo state, with no other correctness or maintainability issues rising to this lane's high-signal bar. Branch: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9eb81e931
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
A not-wrapper test would also run the control against the direct .mjs engine in the dual-gate run and fail it; detect the legacy Bash engine positively and skip every other flavor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Summary
The planning pass for Phase 6 (engine Node port), the last unplanned phase of the standards-sync-audit remediation. Executes ledger decision Q12 (Node port approved; yq-adapter rejected — not relitigated). Grounded on a fresh-context exploration of the engine contract at origin/main
e6b9155and stress-tested by two independent fresh-context reviews (a plan reviewer and an adversarial devils-advocate): 2 CRITICAL and 8 IMPORTANT deduplicated findings, all verified against the live repos and folded in (details in the PLAN's stress-test summary).Closes #451
Fix
Adds to
docs/topics/standards-sync-audit/PLAN.md: the Phase 6 contract description (six subcommands, byte-exact outputs, spawn-batching contract, yq behaviors needing a real YAML AST); four decisions pending user approval — 6-Ayamldependency with the ajv dev-split and PINNED parser configuration, 6-B exec-wrapper entrypoint continuity, 6-C staged dual-gate cutover, 6-D no-Node control inversion plus the control-char-equivalence disposition; five sequential sub-phases (6.1 port + dual-gate suite, 6.2 threat-model re-run + npm supply-chain assessment, 6.3 reusable prep with per-job paths, 6.4 one-file cutover + Bash retirement, 6.5 close-out), each with mechanically verifiable Sanity Checks; the HIGH blast-radius entry; the stress-test summary; execution-shape rows; and the approval-gate rows. Also corrects the Brief's suite figure in prose (929 lines, post-5.3) and extends the Mechanical-work PR series list.Verification
markdownlintgreen on the edited file (pre-commit); comment-hygiene green (no trip shapes in the added prose).Sanity Checkblocks; all sub-phases tagged[PENDING]; all four Brief acceptance items (suite green on Node, threat-model re-run, no-Node control disposition, supply-chain assessment) map to sub-phases; decisions surfaced in the approval-gates section; blast-radius entry present.Related
docs/topics/standards-sync-audit/PLAN.md(Brief acceptance line) and ledger decision Q12 in the audit's decision register.