docs(agent-orientation): add exec-bit staging guidance for new shebang files - #396
docs(agent-orientation): add exec-bit staging guidance for new shebang files#396kyle-sexton wants to merge 1 commit into
Conversation
…g files Restores content to the trimmed-down orientation.md (#394), which established that lines return only with stumble-ledger evidence per the rebuild rule. The exec-bit gate's own CI diagnostic already prints the fix (`git update-index --chmod=+x`), but that only surfaces after a round trip; this line exists to prevent the round trip, not to explain a failure that already happened. Adds this to orientation.md (the materialized AGENTS.md) rather than components/local-lane-guards/README.md because the README documents the guard for standards' own contributors and is not synced to any consumer repo (distribution/sync-manifest.yml only ships the guard scripts, not the README) — orientation.md is the only artifact of this component that actually reaches an agent working in a consumer repo. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @kyle-sexton's task in 1m 47s —— View job Code review complete
Scope: single file, doc-only addition ( Findings: none that clear the high-signal bar. This is a clean, low-risk addition. What I independently checked (not just restating the PR body):
No inline comments were needed — nothing anchored to a specific line rose to blocking or important. |
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
|
Closing this against the rebuild rule it would have to clear. The work is sound; the evidence bar is not met. Recording the full analysis so a future re-add starts from here rather than re-deriving it. Why this is closed rather than merged
Neither half is met.
And The honest counter-argument is that the doc prevents a CI round-trip where the gate only teaches Findings worth keeping, independent of this PR
What would reopen thisA stumble ledger showing repeated exec-bit failures from the same cause. If that accumulates, |
Summary
Restores exec-bit staging guidance to
components/agent-orientation/orientation.md— the source of the materializedAGENTS.mdsynced into consumer repos — so a Windows-specific staging trap is caught before a commit instead of after a CI round trip.Fix
components/agent-orientation/orientation.md: adds a second section, "New shebang files land in the index as non-executable." Explains thatcore.filemode=false(the Windows default) makes a newly staged shebang file land at git mode100644regardless of intended use, that the exec-bit gate (components/local-lane-guards/check-exec-bit.sh) rejects any tracked100644shebang file, and that the failure only surfaces after a CI round trip — so it names the fix (git update-index --chmod=+x -- <path>) to run before committing, not after the gate fails.orientation.mdrather thancomponents/local-lane-guards/README.md(which already documents the guard's layout and local invocation) because the README is not synced anywhere —distribution/sync-manifest.ymlships only the guard scripts underlocal-lane-guardstotools/shared/local-lane-guards/<file>, never the README.orientation.mdis the only artifact of this component that reaches an agent working in a consumer repo, so pointer-not-copy isn't available here: the guidance has to live where it's read.This re-adds content to a file #394 deliberately trimmed to only the synced-standards warning, under the rebuild rule established there ("lines return only with stumble-ledger evidence"). The evidence is below.
Verification
npm run lint:md— 0 issues across 113 files.distribution/sync-manifest.sh validate— manifest valid (37 components, 8 targets).bash distribution/sync-manifest.test.sh— 1312/1314 pass. The 2 failures (manifest symlink is rejected before parsing, its diagnostic-text sibling) reproduce identically in a fresh clone ofmainat this PR's base commit (2386434), unmodified — a Windows environment limitation (ln -sneeds elevated privileges/Developer Mode), not a regression from this diff.bash components/local-lane-guards/run-local-lane-guards.sh exec-bit— dogfoods the guard this note documents; passes (no shebang files in this change).Related
No linked issue.
git update-index --chmod=+x) had to be inlined into the issue body because the guidance existed nowhere else, costing a CI round trip.orientation.mdinstead of there).🤖 Generated with Claude Code