fix(path-detection): broaden Windows checkout-root names beyond repos - #250
Merged
Merged
Conversation
Backfill the broadened HPP_WIN_REPO_BODY / HPP_ESCAPED_WIN_REPO_BODY checkout-root alternation (repos|Repos|projects|Projects|dev|Dev) that claude-code-plugins#932 shipped directly in its managed materialization, and pin the new roots with contract tests. Restores upstream-downstream convergence so the standards-sync PR stops reverting the reviewed downstream behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFq1q99cNeZjKhDzHv2BQw
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
|
Warning Automated review did not complete — this is an infrastructure failure, not a review verdict. Treat any Claude comment on this PR (including a placeholder like "I'll analyze this and get back to you") as incomplete, not "no findings."
Re-running the job, or pushing a new commit, will retry the review. |
This was referenced Jul 23, 2026
kyle-sexton
added a commit
that referenced
this pull request
Jul 23, 2026
…ing separator (#255) ## Summary The five `HPP_*` bodies required a separator AFTER the child segment, which inverted detection both ways in a live consumer incident (melodic-software/claude-code-plugins#1093): - A real bare path value at end of line (`root = <drive>:/Dev/GitHub`) has no trailing separator and was **missed** — a false negative on exactly the config-value shape the bodies exist to catch. - Prose satisfied the requirement anyway: the space-permitting segment class greedily consumed words until a later slash on the same line, flagging a comment as a "Windows repo path" while the actual violations passed clean. Fix: the segment classes now exclude whitespace and the double quote, and the mandatory trailing separator is gone. Bare values at a natural boundary (EOL, whitespace, quote) are detected; prose spans cannot match (at least one non-space child character must follow the root); a root with NO child segment (`C:\Users`, a lone `D:/repos/`) still never matches. ## Deliberately flipped pins `machine-path-patterns.test.sh` pinned "bare roots stay clean" as a regression guard. Those pins are flipped, not worked around: that design's only stated rationale was prose safety, which the whitespace-excluding class now provides without the false-negative cost. New pins cover both directions of the old inversion (bare values must flag; prose spans must not — including a span-equality assertion that the prose line's match is the path token itself, never a greedy span). README updated to match (cross-doc reconciliation done in-PR; no other doc references the old boundary semantics). ## Consumer impact (manifest targets) Semantic widening reaches all three mapped targets on next sync — bare home/checkout values will start flagging: - **claude-code-plugins** (`path-detection-guardrails`): already carries the identical body file plus a bare-form update to its `/Users/Shared` exclusion stage — melodic-software/claude-code-plugins#1095. Local and upstream copies are byte-identical. - **medley** (`path-detection-tools`): its hook-layer driver has the same `/Users/Shared/` exclusion shape (`tools/shared/path-detection/hardcoded-path-patterns.sh`) and needs the same one-line bare-form follow-up when this syncs. - **ci-workflows** (`path-detection-action`): no affected exclusion stage found in `check-machine-specific-paths.sh`. ## Verification - `components/path-detection/machine-path-patterns.test.sh` **34/0** - shellcheck clean on both files (the escaped body's `SC1003` disable became unnecessary — no trailing backslash remains) 🤖 Generated with [Claude Code](https://claude.com/claude-code) ## Related No linked issue — the driving incident is tracked downstream: melodic-software/claude-code-plugins#1093 (consumer bug report), fixed there by melodic-software/claude-code-plugins#1095 with this component change mirrored byte-identically. Prior art: #250 (checkout-root broadening from the same consumer chain). Co-authored-by: Claude Fable 5 (200k context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backfills the broadened Windows checkout-root alternation (
repos|Repos|projects|Projects|dev|Dev) inHPP_WIN_REPO_BODY/HPP_ESCAPED_WIN_REPO_BODYthat melodic-software/claude-code-plugins#932 shipped directly in its managed materialization, plus contract tests pinning the new roots.Without this,
standards-synckeeps proposing a revert of the reviewed downstream behavior: the current sync PR (melodic-software/claude-code-plugins#951) stomps the broadened patterns and fails the downstream guardrails contract tests (hardcoded-path-check.test.sh: "windows Projects checkout root" cases). After this merges, the push-triggered sync refreshes that PR to the runner-policy lockfile change only, unblocking Dependabot alert remediation there.The component file is byte-identical to the downstream reviewed copy (blob
785d1809).Related
No linked issue.