docs(issue-tracker): require --type on issue creation; reconcile Related scope - #247
Conversation
…ted scope Adds the rule that CLI/agent issue creation always passes --type with an enabled native type, since the web-UI form path already surfaces the field. Corrects an unverified no:type search-qualifier claim discovered wrong by empirical check, and reconciles the ## Related section requirement from requires-ci-scoped phrasing to the fleet-wide convention it already is, preserving the provisioning-origin historical note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KYvF6bWGqemS9aYFfWJRiW
|
Claude finished @kyle-sexton's task in 1m 30s —— View job PR Review
One changed file: Overall verdict: looks good. The 🟡 Nit 1 —
In a backtick span, 🟡 Nit 2 — "can't skip it" may be stronger than warranted
"Can't skip it" implies the field is enforced/required on the form. If the field is surfaced but still optional (no required-field validation on the web form), a user who clears the selector can still submit without a type. The weaker phrasing "is unlikely to skip it" or "surfaces the Types field as a first-class input, reducing the risk of an unset type" matches the actual guarantee more precisely. If the org has configured the field as required on the form, a parenthetical confirming that would make the strong claim defensible. Fix this → No other findings. The |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28f227c7ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🔒 babysit-prs lane claiming this PR for on-branch fix work this cycle (amendment-round: 16, safe tier). Will fix clear branch-owned findings and push; will not resolve threads or merge (safe tier). Releasing claim implicitly once this cycle's cadence report posts. |
|
Claude finished @kyle-sexton's task in 2m 8s —— View job PR Review — Amendment Round
Both nits from the prior review are still present in the current file. I prepared the fix locally but the push was denied (403 — File: -**Issue creation always sets the type.** CLI and agent-driven issue creation passes `--type` with one of the org's enabled native types (`gh issue create --type Task|Bug|Feature`); the web UI's issue form already surfaces the Types field, so that path can't skip it.
+**Issue creation always sets the type.** CLI and agent-driven issue creation passes `--type` with one of the org's enabled native types (`gh issue create --type <Task|Bug|Feature>`); the web UI's issue form already surfaces the Types field as a first-class input, making it unlikely that path skips it.Two changes in one line:
No other findings. The |
…nt claim Codex review on PR #247: gh issue create --type Task|Bug|Feature reads as a pipe on copy-paste, executing Bug/Feature as commands. Show one concrete value with the allowed set stated in prose. Also corrects an implication that the web form enforces the Types field -- GitHub does not; setting it is this policy's requirement on both paths, consistent with the preceding paragraph's "GitHub does not require every issue to carry a type." Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KYvF6bWGqemS9aYFfWJRiW
|
Claude finished @kyle-sexton's task in 1m 17s —— View job PR Amendment Review
Both nits from the prior review round are resolved in commit Nit 1 — shell-hostile Nit 2 — "can't skip it" overclaim: Resolved, and resolved more accurately than the suggested softening. Rather than hedging to "unlikely to skip it," the new text states the fact plainly: "GitHub does not force it to be filled in there either; setting it is this policy's requirement, not something the platform enforces on either path." This is internally consistent with the paragraph above it (which already explains that GitHub doesn't require a type) and more useful to the reader than a hedged probability claim. Both Codex P2 findings are also addressed by the same edits. No remaining findings. The three substantive changes in this PR — the |
No related issue: rule additions decided on melodic-software/medley#1623 and melodic-software/claude-code-plugins#975
Summary
--typewith one of the org's enabled native types (Task/Bug/Feature); the web-UI issue form already surfaces the Types field so that path can't skip it. Placed inconventions/process/issue-tracker.md's existing "The type axis" section.no:typesearch qualifier exists to find untyped issues. Empirically disproved against the live org (org:melodic-software is:issue is:open no:typereturned the unfiltered total of 336, identical to the query with nono:typeclause at all — GitHub silently drops the unrecognized qualifier rather than erroring). Replaced with an accurate description: search exposes a positivetype:"Bug"-style qualifier per enabled type but no negation for "untyped"; finding the untyped remainder means comparing per-type counts against the total, or reading an issue'stypefield (nullwhen unset).## RelatedPR-section requirement from requires-ci-scoped phrasing ("became the org-wide rule when the sharedpr-issue-linkagegate generalized it to every requires-ci repository") to the fleet-wide convention locked in claude-code-plugins#975's Q12 decision — the practice applies org- and account-wide by convention even where no CI gate exists to check it mechanically (e.g.songwriting,knowledge-corpus). Preserves the one-line historical note that it began asprovisioning's stricter convention (decisions log fix(lychee): exclude private constellation repos from the online lane #58/feat(dotnet): enable NuGet lock files in the overlay #59).Related
🤖 Generated with Claude Code
KNOWN ISSUE: hosted CI may fail 0-step/2s (billing) — environmental, note and continue.