Skip to content

ci: bump the standards-sync contract to the linkage-compliant template - #201

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/bump-standards-sync-0b45b9f
Jul 18, 2026
Merged

ci: bump the standards-sync contract to the linkage-compliant template#201
kyle-sexton merged 1 commit into
mainfrom
ci/bump-standards-sync-0b45b9f

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

What

Register standards-sync.yml@0b45b9f in the runner policy (contract body copied from the reviewed ec91c343 entry), record the lockstep provenance note, and move sync.yml's pin to it.

Why

The sync wave still ran standards-sync@ec91c34, which predates the PR-body template fix — every distributed sync PR failed its target's pr-issue-linkage gate and needed a hand-patched body (dotfiles#225, provisioning#175, claude-code-plugins#345 this wave). The ec91c343..0b45b9f diff for the reusable is confined to the body heredoc: it adds the "No linked issue" sentence and a ## Related section (melodic-software/ci-workflows#146); inputs, secrets, permissions, and routing are unchanged.

Verification

224/224 runner-policy component tests pass; the policy engine passes with public visibility evidence; actionlint clean on sync.yml; markdownlint + biome + lefthook gauntlet green.

Related

No linked issue. melodic-software/ci-workflows#146 (template fix), #200 (public posture this builds on).

🤖 Generated with Claude Code

https://claude.ai/code/session_01YZxBP1B8Hf7ZRaqDrP6ma9

Register standards-sync@0b45b9f (copying the reviewed ec91c343 contract
body — the revision diff is confined to the generated sync-PR body
heredoc, which gains the "No linked issue" sentence and a "## Related"
section per ci-workflows#146) and move sync.yml's pin to it, so future
sync waves open PRs that pass each target's pr-issue-linkage gate
instead of needing hand-patched bodies. Lockstep provenance note
recorded; 224/224 component tests and the policy engine pass.

Co-Authored-By: Claude Fable 5 (1M context) <noreply@anthropic.com>
@claude

claude Bot commented Jul 18, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 1m 39s —— View job


Code Review

  • Gather context and read changed files
  • Review policy.json — new contract entry correctness
  • Review README.md — provenance note accuracy
  • Review sync.yml — pin update correctness
  • Post findings

Summary: The change is narrowly scoped and internally consistent. No blocking issues found.

policy.json — new contract entry

The new 0b45b9f entry is byte-for-byte identical to the existing ec91c343 entry — same routing, runnerInput, allowedInputs, and allowedSecrets. That's the correct approach when only the body heredoc changed upstream: the security surface is unchanged, so the contract review carries over. No secrets are introduced; the values remain template-expression references to existing Actions secrets. ✅

The ec91c343 entry is correctly retained rather than removed (old entries stay as the audit trail for any consumers still on that pin). ✅

sync.yml — pin update

The full SHA in the uses: line (0b45b9fb1755649455e3bb2b9c56c619a412b06b) matches the key added to policy.json exactly. The inline comment (# 0b45b9f 2026-07-18) correctly abbreviates to 7 chars and carries the right date. ✅

README.md — provenance note

The provenance note correctly describes the scope of the upstream diff, attributes it to ci-workflows#146, and confirms the security-relevant fields are unchanged. One minor inconsistency worth noting:

🟡 Nit — The README spells out the predecessor as ec91c343 (8 hex chars) while the sync.yml inline comment and the PR body both use ec91c34 (7 chars). The style elsewhere in this file uses the shorter 7-char form (e.g., the PR body, the sync.yml comment). The 8-char form is unambiguous, but a uniform abbreviation length would be more consistent with the rest of the document. Fix this →


LGTM. The security surface of the new entry is identical to the reviewed predecessor, the diff is purely cosmetic (PR body template), and the three-file change is internally consistent.

@kyle-sexton
kyle-sexton merged commit 1a8fcda into main Jul 18, 2026
42 checks passed
@kyle-sexton
kyle-sexton deleted the ci/bump-standards-sync-0b45b9f branch July 18, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant