Skip to content

docs: onboard github-iac as a lychee consumer - #145

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/onboard-github-iac-lychee
Jul 16, 2026
Merged

docs: onboard github-iac as a lychee consumer#145
kyle-sexton merged 1 commit into
mainfrom
docs/onboard-github-iac-lychee

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes decision #70 (Decisions Log: https://claude.ai/code/artifact/232ecdce-8316-4880-8c0a-dc3c7dcf3a63) — the upstream half: "add link-check.yml to github-iac" turned out to need this first.

melodic-software/github-iac was the only repo missing lychee from its managed list in distribution/sync-manifest.yml — every other lychee.toml-carrying repo already had it. That's the actual root cause of the missing link-check.yml: there was nothing to sync from.

The companion melodic-software/github-iac PR (melodic-software/github-iac#132) materializes the synced lychee.toml via this repo's own distribution/sync-manifest.sh apply — not hand-copied — and adds the .github/workflows/link-check.yml caller.

Verification

  • distribution/sync-manifest.sh validate: passes (21 components, 8 targets).
  • distribution/sync-manifest.sh plan --targets melodic-software/github-iac: shows lychee.toml as the only new mapping; every other managed component unchanged (idempotent — confirms nothing else drifts from this edit).

Closes decision #70 (Decisions Log:
https://claude.ai/code/artifact/232ecdce-8316-4880-8c0a-dc3c7dcf3a63) --
half of it: this is the upstream side of "add link-check.yml to
github-iac". github-iac was the only lychee.toml-carrying repo's
governed-repo peer never actually listed as a lychee consumer in this
manifest -- every other repo with a lychee.toml already was. That's the
real root cause of the missing link-check.yml: there was nothing to sync
from.

The companion melodic-software/github-iac PR materializes the synced
lychee.toml via this repo's own distribution/sync-manifest.sh apply (not
hand-copied) and adds the .github/workflows/link-check.yml caller.

Verification: distribution/sync-manifest.sh validate passes (21
components, 8 targets); distribution/sync-manifest.sh plan --targets
melodic-software/github-iac shows lychee.toml as the only new mapping,
every other managed component unchanged (idempotent).
@claude

claude Bot commented Jul 16, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 55s —— View job


PR Review

  • Gather context
  • Read CLAUDE.md and REVIEW.md guidelines (no CLAUDE.md or REVIEW.md found in repo)
  • Examine the changed file
  • Review the diff
  • Post findings

Verdict: LGTM — approve and merge.

This is a correct, minimal, one-line addition. Everything checks out:

Change is accurate and consistent

distribution/sync-manifest.yml L173 adds - lychee to the melodic-software/github-iac target's managed list. The lychee component is properly defined in the components section (L67–69 with lychee.toml: lychee.toml), and every other target in the manifest (melodic-software/.github, ci-runner, ci-workflows, claude-code-plugins, dotfiles, provisioning) already carries lychee in its managed list. This was genuinely the only omission.

Alphabetical ordering is correct

The new entry slots between lefthook-dotnet and markdownlint, which is the right alphabetical position within github-iac's managed list — consistent with how other targets maintain their ordering.

PR description is accurate

The claim that github-iac was "the only repo missing lychee from its managed list" is confirmed by reading the file. The verification steps (validate + plan --targets) are exactly the right checks to run for a manifest edit.

No issues found.

@kyle-sexton
kyle-sexton marked this pull request as ready for review July 16, 2026 13:24
@claude

claude Bot commented Jul 16, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 49s —— View job


PR Review

  • Read changed file and diff
  • Verify component definition exists
  • Verify alphabetical ordering
  • Cross-check against other targets
  • Post findings

Verdict: LGTM — approve and merge.

Single-line addition to distribution/sync-manifest.yml L173 — adding - lychee to the melodic-software/github-iac target's managed list.

Change is correct and consistent

The lychee component is properly defined in the manifest's components section (L67–69, lychee.toml: lychee.toml). Every other target in the file already carries lychee in its managed list; github-iac was the only omission. The fix is accurate.

Ordering is correct

The new entry slots between lefthook-dotnet and markdownlint — the right alphabetical position within github-iac's managed list, consistent with how every other target maintains ordering.

PR description is accurate

The root-cause explanation (nothing to sync from → missing link-check.yml downstream) and the verification steps (validate + plan --targets) match what the code shows.

No issues found.

@kyle-sexton
kyle-sexton merged commit 05f4356 into main Jul 16, 2026
41 checks passed
@kyle-sexton
kyle-sexton deleted the docs/onboard-github-iac-lychee branch July 16, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant