Skip to content

chore(runner-policy): retire the superseded drift-check contract - #113

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/retire-stale-drift-contract
Jul 15, 2026
Merged

chore(runner-policy): retire the superseded drift-check contract#113
kyle-sexton merged 1 commit into
mainfrom
chore/retire-stale-drift-contract

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Why

Completes the staged rollout from #111: melodic-software/github-iac#112 merged with the drift-check pin at the reviewed 15aefd8 reference, so the prior @99ac2f8 contract entry has zero consumers (verified via org-wide code search). The allowlist carries no superseded references.

What

  • policy.json: superseded pulumi-version-drift-check.yml@99ac2f8 contract removed
  • runner-policy.test.mjs: single drift-check reference asserted; transitional constant names collapsed

Verification

  • node --test components/runner-policy/runner-policy.test.mjs: 112 pass / 0 fail

🤖 Generated with Claude Code

https://claude.ai/code/session_01JLfjHY8PY6ozhgZPiuHKik

github-iac now pins pulumi-version-drift-check at the reviewed
retirement-aligned commit; the prior reference has no consumers left.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JLfjHY8PY6ozhgZPiuHKik
@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Claude finished @kyle-sexton's task in 55s —— View job


Review

  • Gather context and read CLAUDE.md
  • Review changed files
  • Post review findings

Changes look correct and well-scoped. This is a straightforward retirement of a superseded contract entry. A few notes:

policy.json — The @99ac2f8c entry is removed cleanly. The surviving @15aefd87 entry is untouched and remains correctly configured with identical shape (routing: hosted-only, empty inputs/secrets, ubuntu-24.04). No orphaned references introduced.

runner-policy.test.mjs — The constant collapse is the right call:

  • The old dual-constant approach (PULUMI_DRIFT_REUSABLE_REFERENCEPRODUCTION_SHA, RETIREMENT_PULUMI_DRIFT_REUSABLE_REFERENCERETIREMENT_ALIGNED_GUARD_SHA) was a transitional artifact.
  • The new PULUMI_DRIFT_SHA = "15aefd8..." + single PULUMI_DRIFT_REUSABLE_REFERENCE is cleaner and directly reflects the single surviving contract.
  • The retained assert.deepEqual at line 1273 still exercises the active contract, so coverage isn't reduced — it shifts from asserting two entries to asserting one.

Consistency check: PULUMI_DRIFT_SHA in the test (15aefd8799e8a8b5ffdfcc183dcbfcbf58044481) matches the key remaining in policy.json at line 90. No drift between test fixture and data.

No issues found. LGTM.

@kyle-sexton
kyle-sexton merged commit 4277797 into main Jul 15, 2026
39 checks passed
@kyle-sexton
kyle-sexton deleted the chore/retire-stale-drift-contract branch July 15, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant