Repository navigation
ci(review): add the shadow caller for the launcher-based review lanes - #9292
Closed
kyle-sexton wants to merge 1 commit into
Closed
kyle-sexton wants to merge 1 commit into
kyle-sexton wants to merge 1 commit into
Conversation
pr-review-shadow-hosted.yml calls ci-workflows' pr-review-cli.yml (v0.63.0) in summary mode, one job per lane, on the reviews role's API key alone. A gate job runs it for a pull request that changes the file, else for one numbered a multiple of 4 when REVIEWS_SHADOW_ENABLED is true, under the org and repository kill switches, with the live lanes' model routes. No concurrency block, and every gate step continues on error, so no path leaves a red or cancelled check. lane-funding.json catalogs both lanes under reviews, now keyed, and callers.test.mjs covers the pin, grants, secret, summary mode and the gate's decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Superseded: the owner decided (Q39, 2026-10-23) to drop the review shadow and convert the live review lanes directly onto ci-workflows pr-review-cli.yml, one workflow per lane. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: melodic-software/claude-code-account-rotation#259
Summary
Adds
pr-review-shadow-hosted.yml, a shadow run of ci-workflows' launcher-basedpr-review-cli.yml(v0.63.0) in summary mode, one job per lane (pr-review-shadow,pr-review-security-shadow), beside the live review lanes. It posts nothing: each lane leaves a job summary and a scanned JSON artifact to compare with the live review of the same head.Fix
REVIEWS_CLAUDE_API_KEY) only; no subscription token is passed.REVIEWS_SHADOW_ENABLEDistrueand the number is a multiple of 4. The org and repository lane kill switches stop both.review-codeandreview-securitymodel routes from the default branch; a failure or a subagent model leaves the reusable's defaults, as the live callers do. The security shadow passes the live security lane's docs-only paths.pr-feedback-dispatch.ymland babysit's review evidence never see it.lane-funding.jsoncatalogs both lanes underreviews(now keyed), andcallers.test.mjscovers the pin, grants, secret map, summary mode, the gate's outputs and its decision script.Verification
node --test .github/actions/resolve-config/callers.test.mjs: 124 pass.scripts/check-affected.sh --tests: 9 passed, 5 skipped.runner-policy.mjs: fails on both lane jobs, because no reviewed contract exists yet forpr-review-cli.yml@8778094. The contract has to be registered in melodic-software/standards and synced here before this can merge.Related
🤖 Generated with Claude Code