Skip to content

feat(debugging): add minimize, pristine-copy diff and HITL template note to debugging:debug - #8828

Merged
melodic-automation-lanes[bot] merged 1 commit into
mainfrom
work-resolve-issue/issue-8825-39545088490-1
Oct 21, 2026
Merged

melodic-automation-lanes[bot] merged 1 commit into
mainfrom
work-resolve-issue/issue-8825-39545088490-1

Conversation

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor

Closes #8825

Summary

Opened by the work-resolve-issue lane. The run's own summary:

Adds a Minimize step to Phase 2 of /debugging:debug (gate extended), a pristine-copy diff sentence to Phase 5 step 2, and a note in the human-driven loop paragraph that ask answers are pasted back so sign-in stays an instruct step. The checklist and README Phase 2 lines gain the minimize step, three eval cases are added, and a minor changelog fragment is written.

Not verified

  • CI's check-skills and lint-repo were not run here; left to the PR's CI
  • Changes are left uncommitted in the working tree per the runner's instructions
  • review-venue.txt was absent, so the review ran as a local subagent

Fix

  • plugins/debugging/skills/debug/SKILL.md: new ### Minimize subsection and extended Phase 2 gate; pristine-copy diff sentence in Phase 5 step 2; HITL note after the human-driven loop paragraph pointing to the secrets heading
  • plugins/debugging/skills/debug/templates/checklist.md: Phase 2 line gains the minimize step
  • plugins/debugging/README.md: Phase 2 line gains the minimize step
  • plugins/debugging/skills/debug/evals/evals.json: cases 15 (minimize), 16 (forced red), 17 (human-driven loop)
  • .changes/debugging/feat-8825-minimize-pristine-diff-3c9e5a17.md: bump minor, Added entry, written by hand

Verification

The runner ran each check from the base copy against 1b0d41b:

  • scripts/check-changelog-fragments.sh --check: passed

The run reports:

Left out: the items under Not verified.

Related

#8825

Lane-Activity: work-resolve-issue/resolve-issue
@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 1b0d41b0bf4ab89078cc4b520e2c1b69d3995844: 0 finding(s), 0 as inline comments.

No security findings in PR #8828 at head 1b0d41b.

The PR changes only skill prose, a README line, a checklist template, eval cases and a changelog fragment for /debugging:debug. It adds no executable code, workflow, hook, permission or dependency change.

I read the diff under the instruction-surface lens. Nothing is deleted, narrowed or softened. One addition tightens a control: it tells the skill never to ask for passwords, tokens or secrets in the human-driven script, and to leave sign-in to an instruct step. That wording cross-references the existing "Secrets stay out of what you show" section. The new eval 17 checks this behavior. Because no standing rule is removed, I did not consult the instruction exception register.

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 1b0d41b0bf4ab89078cc4b520e2c1b69d3995844: 0 finding(s), 0 as inline comments.

No findings. I read the full diff, the PR context and closing issue #8825, and the changed parts of plugins/debugging/skills/debug/SKILL.md. I did not run CI checks. The author's claimed check results are unverified by me.

Each criterion in #8825 that can be read from the diff is met:

  • Minimize: Phase 2 has a ### Minimize subsection placed before the gate. The gate now names minimizing, and the rule for intermittent bugs uses the failure rate.
  • Pristine-copy diff: Phase 5 step 2 gains the one added sentence.
  • Human-driven loop note: The paragraph says ask answers are pasted back and that signing in stays an instruct step. The cross-reference "Secrets stay out of what you show" matches an existing heading (SKILL.md:54).
  • Added text only: The SKILL.md additions are new text apart from the extended gate line. The one-line checklist and README edits only extend the Phase 2 line.
  • Unchanged files: hitl-loop.template.sh is not in the diff, and no added file is executable.
  • Evals: Cases 15, 16 and 17 are prompt-only with files: []. Their expectations are specific and match the new text.
  • Changelog fragment: It has bump: minor and an ### Added entry, as the issue asks.

The new text adds no volatile upstream specifics, prices or provenance notes, so the path-scoped rules for skill bodies and cost claims are not triggered.

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

The unattended merge path enqueued this pull request at head 1b0d41b0bf4ab89078cc4b520e2c1b69d3995844.

@melodic-automation-lanes
melodic-automation-lanes Bot added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit e6cdca0 Oct 21, 2026
33 checks passed
@melodic-automation-lanes
melodic-automation-lanes Bot deleted the work-resolve-issue/issue-8825-39545088490-1 branch October 21, 2026 05:02
@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

Unattended merge: risk MED at head 1b0d41b0bf4ab89078cc4b520e2c1b69d3995844. Only LOW merges without a human. This pull request waits for one.

MED evidence-unbound:claude-review: not bound: no-run
MED evidence-unbound:claude-security-review: not bound: no-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(debugging): add minimize, pristine-copy diff and HITL template note to /debugging:debug

0 participants