Skip to content

docs(adr): record code-design review ownership and phase-boundary dispatch - #8422

Merged
kyle-sexton merged 3 commits into
mainfrom
docs/adr-code-design-review-owner
Oct 19, 2026
Merged

kyle-sexton merged 3 commits into
mainfrom
docs/adr-code-design-review-owner

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: #8326

Summary

Records two decisions the code-design defaults effort already shipped, so a later reader can find why they hold:

  • ADR 0078: the review plugin owns the code-design review criteria and severity as /review:quality-gate code-design; planning cites it by invocation and implementation invokes it.
  • ADR 0079: /implementation:implement and /implementation:implement-dispatch dispatch each phase's Review: tag to /review:quality-gate <mode> at the phase boundary, report-only, with one re-review and a single escalation.

Fix

Two new files under docs/adr/, numbered after 0077, in the shape of the newest records (Status, Date, Related, Context, Decision, Why, Alternatives considered). Each cites the current behavior by file:line. No other file changes.

Verification

  • typos --format brief on both files: no output.
  • bash scripts/check-affected.sh: 5 passed, 3 skipped over 2 changed files; the lefthook pre-push run passed too.
  • markdownlint-cli2 on both files: 0 issues.

Related

🤖 Generated with Claude Code

kyle-sexton and others added 2 commits October 19, 2026 09:23
…patch

ADR 0078: the review plugin owns the code-design review criteria and
severity as /review:quality-gate code-design; planning cites it by
invocation and implementation invokes it.

ADR 0079: /implementation:implement and implement-dispatch dispatch each
phase's Review: tag to /review:quality-gate at the phase boundary,
report-only, with one re-review and a single escalation.

Refs: #8326

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review October 19, 2026 13:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T13:27:37.106414Z e498180 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review needs no new review of c06978d226a6d2c4cedfb8523eea7b673eb7ed84: every file in scope matches docs-only-paths.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e498180520

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed c06978d226a6d2c4cedfb8523eea7b673eb7ed84: 0 finding(s), 0 as inline comments.

No findings. I reviewed only the incremental change to ADR 0078 and ADR 0079.

  • What changed: The change replaces file:line citations of skill files with citations by invocation, in the form /plugin:skill plus a section name. That matches the repository rule that cross-plugin citations name the skill, never a path.
  • Checked: I grepped the cited skills.
    • /implementation:implement has the cited bold heading "Phase-boundary review, before the ritual" at plugins/implementation/skills/implement/SKILL.md:212.
    • The one-re-review rule and the DEVIATIONS.md escalation are still in /implementation:implement, and the unattended-denial handling is in /implementation:implement-dispatch (line 245).
    • The ADR 0078 sentence about the /review:quality-gate code-design mode no longer carries a path or line number. The context file it describes, plugins/review/skills/quality-gate/context/code-design.md, still exists.
  • Not verified: I did not open the quality-gate SKILL.md or design-principles.md, and I did not run the author's typos, markdownlint-cli2 or check-affected.sh checks. Their results are the author's claims.

AGENTS.md and the plugin philosophy bar docs from citing a skill's files by
path; ADR 0078 and 0079 now name /review:quality-gate,
/implementation:implement and /implementation:implement-dispatch, and the
linked PRs carry the implementation evidence.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit e77ca8a Oct 19, 2026
17 checks passed
@kyle-sexton
kyle-sexton deleted the docs/adr-code-design-review-owner branch October 19, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant