Repository navigation
feat(planning): add a design-principles reference cited to canonical sources - #8393
Conversation
One directive line per foundational principle (SRP, OCP, LSP, ISP, DIP, composition over inheritance, DRY of knowledge, coupling and cohesion, information hiding, deep modules and change amplification, YAGNI's cheap-now test, reuse first), each cited to its defining source with an as-of date and a recheck trigger. It opens with the scope line and the consumer-wins override line, and points at /review:quality-gate code-design for review-time criteria. Refs: #8332 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… design principles Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security issues found in PR #8393 at head f6b964b. The PR adds two files: a changelog fragment and The diff deletes, narrows or softens no standing instruction, so the instruction-surface lens found nothing to check against the exception register. The new reference tells agents to apply a consumer's own standards over its defaults and to record the override. That is guidance for design-time defaults. It does not weaken any guardrail, and it gives no way to bypass a hook, a permission rule or a validator. The external links are citations only. The file instructs no fetching and runs nothing from them. |
|
claude-review reviewed No findings. I reviewed both changed files: the new Checked against #8332's acceptance criteria. I ran these checks myself:
I did not independently verify the author's claimed phase-verifier, I found no closing-issue criteria that the change fails to meet, and no path-scoped rule that applies. The |
Closes #8332
Summary
Adds
plugins/planning/reference/design-principles.md, a bundled reference of foundational design principles that planning and implementation skills can read at design time. Each principle is one directive line cited to its defining canonical source, with an as-of date and a recheck trigger. Review-time checking of the same concerns stays with/review:quality-gate code-design, which the reference points at.Fix
plugins/planning/reference/design-principles.md: SOLID, composition over inheritance, DRY of knowledge, coupling and cohesion, information hiding, deep modules, YAGNI's cheap-now test and reuse first. It applies to code, Markdown, skills and agent instructions, and a consumer's own standards override it..changes/planning/(minor bump).Verification
/review:quality-gate code-designresolves on main (landed in feat(review): add /review:quality-gate code-design mode #8388) after mergingorigin/maininto the branch.bash scripts/check-affected.sh --tests --base origin/main: 7 passed, 2 skipped (no shell or Python changed).typoson the changed files: clean.Related
code-designmode to/review:quality-gate)🤖 Generated with Claude Code