Repository navigation
feat(work-items): integrate at least daily in decompose's window bar #8382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c8b280b
feat(work-items): decompose window bar adds integrate-at-least-daily …
kyle-sexton 78a0c17
test(work-items): accept same-day merge in the daily-integration grader
kyle-sexton 57f73d2
Merge branch 'main' into feat/8328-decompose-daily-integration
kyle-sexton 35d4dba
fix(work-items): anchor decompose window-bar pointers and fix eval lint
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.changes/work-items/feat-8328-decompose-daily-integration-6b1e4d9a.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| bump: minor | ||
| --- | ||
|
|
||
| ### Changed | ||
|
|
||
| - `/work-items:decompose` window bar now also asks that a slice can merge to the mainline at least daily, as practice guidance on integration cadence; it sets no hours estimate and no day cap. |
2 changes: 2 additions & 0 deletions
2
plugins/work-items/evals/decompose-slice-checks-daily-integration/case.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| schema_version: "1.1" | ||
| name: decompose-slice-checks-daily-integration |
14 changes: 14 additions & 0 deletions
14
...ms/evals/decompose-slice-checks-daily-integration/graders/applies-window-bar.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| type: llm | ||
| --- | ||
|
|
||
| The prompt asks for the four checks on a small draft vertical slice (a `--month` flag, its config | ||
| key, the code path and a test, no other slice needed). | ||
|
|
||
| PASS if the reply gives a verdict for the window bar saying the slice fits one fresh context window, | ||
| states that the slice can also integrate (merge to the mainline) at least daily, and gives no hours | ||
| estimate, time estimate or one-day cap. | ||
|
|
||
| FAIL if the reply omits the daily-integration check, estimates the work in hours or days, sets a day | ||
| cap, says the slice cannot integrate at least daily without reshaping it as the fix, or runs no | ||
| window-bar check. | ||
5 changes: 5 additions & 0 deletions
5
.../decompose-slice-checks-daily-integration/graders/mentions-daily-integration.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| type: regex | ||
| pattern: '(?<!\bnot\s)(?<!n''t\s)(?<!\bcannot\s)(?<!\bnever\s)\b(integrate[sd]?|integrating|integration|merg\w*)\s+(\w+\s+){0,5}?(at\s+least\s+daily|the\s+same\s+day|within\s+(a|one)\s+day)\b' | ||
| flags: i | ||
| --- |
6 changes: 6 additions & 0 deletions
6
...ems/evals/decompose-slice-checks-daily-integration/graders/no-hours-estimate.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| type: regex | ||
| pattern: '(?<!\bno\s)(?<!\bnever\s)(?<!\bnot\s)\b\d+(\.\d+)?[\s-]*(hours?|hrs?)\b' | ||
| flags: i | ||
| match: not_contains | ||
| --- |
16 changes: 16 additions & 0 deletions
16
plugins/work-items/evals/decompose-slice-checks-daily-integration/prompt.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| --- | ||
| description: "A vertical slice that fits one fresh context window is also checked for integrating at least daily, with no hours estimate" | ||
| tags: [decompose, slice-size] | ||
| runs: 3 | ||
| max_turns: 20 | ||
| timeout_seconds: 300 | ||
| allowed_tools: [Read, Glob, Grep, Skill] | ||
| expected_outcome: "Applies the window bar to the draft slice, finds it fits one fresh context window, also states it can merge to the mainline at least daily, and gives no hours estimate or day cap" | ||
| --- | ||
|
|
||
| Load /work-items:decompose and apply its four checks to this draft vertical slice. Report one line per | ||
| check, then say what to do with the slice. | ||
|
|
||
| Draft slice: "Add a `--month` flag to the refund export command, with the config key it reads, the | ||
| code path that honors it, and a test that runs the command for one month." It touches three files and | ||
| needs no other slice to run. |
46 changes: 46 additions & 0 deletions
46
...ms/evals/decompose-slice-checks-daily-integration/samples/mentions-daily-integration.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| { | ||
| "pass": [ | ||
| { | ||
| "answer": "Window bar: passes. One cold session finishes it in one fresh context window, and it can merge to the mainline at least daily.", | ||
| "why": "direct statement" | ||
| }, | ||
| { | ||
| "answer": "Window bar: fits one window; the team can integrate at least daily. No estimate in hours or days is needed.", | ||
| "why": "negated hours mention" | ||
| }, | ||
| { | ||
| "answer": "Window bar passes: it will merge at least daily as a thin slice.", | ||
| "why": "short form" | ||
| }, | ||
| { | ||
| "answer": "Window bar: pass. A cold session can finish it in one fresh context window and merge it the same day.", | ||
| "why": "same-day merge meets the at-least-daily floor" | ||
| }, | ||
| { | ||
| "answer": "Window bar: pass, thin enough to integrate within a day.", | ||
| "why": "within-a-day form" | ||
| } | ||
| ], | ||
| "fail": [ | ||
| { | ||
| "answer": "", | ||
| "why": "empty run" | ||
| }, | ||
| { | ||
| "answer": "Window bar: passes, one fresh context window. Split it only if it grows.", | ||
| "why": "no daily integration" | ||
| }, | ||
| { | ||
| "answer": "Window bar: this slice cannot integrate at least daily, so split it.", | ||
| "why": "negated daily mention" | ||
| }, | ||
| { | ||
| "answer": "Window bar: passes, about 3 hours of work; merge daily.", | ||
| "why": "bare 'daily' states no floor" | ||
| }, | ||
| { | ||
| "answer": "Window bar: a cold session cannot merge it the same day, so split it.", | ||
| "why": "negated same-day mention" | ||
| } | ||
| ] | ||
| } |
34 changes: 34 additions & 0 deletions
34
.../work-items/evals/decompose-slice-checks-daily-integration/samples/no-hours-estimate.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "pass": [ | ||
| { | ||
| "answer": "Window bar: one fresh context window; integrates at least daily.", | ||
| "why": "no estimate" | ||
| }, | ||
| { | ||
| "answer": "There is no hours estimate and never a day cap; it merges at least daily.", | ||
| "why": "negated mentions" | ||
| }, | ||
| { | ||
| "answer": "It stays a three-file slice, so it merges at least daily.", | ||
| "why": "a number without hours" | ||
| } | ||
| ], | ||
| "fail": [ | ||
| { | ||
| "answer": "Window bar: roughly 4 hours of work, merges at least daily.", | ||
| "why": "hours estimate" | ||
| }, | ||
| { | ||
| "answer": "Window bar passes: a 2-hour slice, integrate at least daily.", | ||
| "why": "hyphenated hours" | ||
| }, | ||
| { | ||
| "answer": "Window bar: about 6 hrs; merges at least daily.", | ||
| "why": "hrs abbreviation" | ||
| }, | ||
| { | ||
| "answer": "Window bar passes; budget 8 hours, merge at least daily.", | ||
| "why": "budgeted hours" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.