Repository navigation
test(source-control): add a setup eval case that writes only what the user confirmed #8162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kyle-sexton
merged 3 commits into
main
from
work-resolve-issue/issue-7998-39106008892-1
Oct 19, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
f92f468
test(source-control): add a setup eval case that writes only what the…
melodic-automation-lanes[bot] e5c433b
test(source-control): drop unreachable skill-fired grader from setup …
melodic-automation-lanes[bot] ad660ea
fix: mark shebang scripts executable
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.changes/source-control/test-setup-eval-writes-only-confirmed-8e4b2c61.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| bump: patch | ||
| --- | ||
|
|
||
| ### Added | ||
|
|
||
| - Plugin-eval case `setup-writes-only-confirmed-change`: `/source-control:setup apply layer=team` runs in a scratch repository where the prompt confirms the team convention file and declines the personal overlay and the neutral convention file. Deterministic `file_exists` graders fail when either declined file appears in the workspace. |
4 changes: 4 additions & 0 deletions
4
plugins/source-control/evals/setup-writes-only-confirmed-change/case.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| schema_version: "1.1" | ||
| name: setup-writes-only-confirmed-change | ||
| context: | ||
| scaffold_script: scaffold.sh |
6 changes: 6 additions & 0 deletions
6
...rol/evals/setup-writes-only-confirmed-change/graders/no-neutral-file-written.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| type: file_exists | ||
| path: docs/conventions/source-control/commit-convention.yml | ||
| exists: false | ||
| arm: both | ||
| --- |
6 changes: 6 additions & 0 deletions
6
...-control/evals/setup-writes-only-confirmed-change/graders/no-overlay-written.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| type: file_exists | ||
| path: .claude/source-control.local.md | ||
| exists: false | ||
| arm: both | ||
| --- |
5 changes: 5 additions & 0 deletions
5
...e-control/evals/setup-writes-only-confirmed-change/graders/team-file-written.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| type: file_exists | ||
| path: .claude/source-control.md | ||
| arm: both | ||
| --- |
12 changes: 12 additions & 0 deletions
12
plugins/source-control/evals/setup-writes-only-confirmed-change/prompt.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| description: Setup apply writes the confirmed team convention and leaves the declined personal overlay and neutral file unwritten | ||
| tags: [setup, source-control] | ||
| runs: 3 | ||
| max_turns: 30 | ||
| allowed_tools: [Read, Glob, Grep, Skill, Bash, Write, Edit] | ||
| expected_outcome: ".claude/source-control.md exists with the ticket-prefixed convention; .claude/source-control.local.md and docs/conventions/source-control/commit-convention.yml were never written" | ||
| --- | ||
|
|
||
| /source-control:setup apply layer=team | ||
|
|
||
| I am answering the interview up front, so do not ask me anything. Our team convention is ticket-prefixed subjects, `^[A-Z]+-\d+: .+`, and I confirm you write that to the team file `.claude/source-control.md`. I decline two other changes: do not create a personal overlay at `.claude/source-control.local.md`, and do not create the neutral convention file `docs/conventions/source-control/commit-convention.yml`. Write nothing else apart from the team file. |
13 changes: 13 additions & 0 deletions
13
plugins/source-control/evals/setup-writes-only-confirmed-change/scaffold.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #!/usr/bin/env bash | ||
| # Seeds the eval workspace with a git repo that has no source-control config at any layer: one commit | ||
| # on main, and the recursive .claude/**/*.local.* ignore rule already in place so apply has no | ||
| # .gitignore edit of its own to make. | ||
| set -euo pipefail | ||
|
|
||
| git init -q -b main | ||
| git config user.name eval | ||
| git config user.email eval@example.invalid | ||
| printf '.claude/**/*.local.*\n' > .gitignore | ||
| printf '# demo\n' > README.md | ||
| git add .gitignore README.md | ||
| git commit -q -m "WEB-101: seed" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.