docs(plugins): drop unreachable repo-root LICENSE pointer from final 13 READMEs (wave 3) - #771
Conversation
…13 READMEs (wave 3) Completes the fleet-wide removal: delete the dangling "See the LICENSE file at the root" sentence, keep the inline MIT/SPDX statement, patch bump + CHANGELOG entry per plugin. Guardrails and work-items stack above entries that landed on main mid-flight (0.9.2 home-gate fix, 0.17.1 linked-PR pagination); songwriting's methodology-attribution note is preserved. Repo-wide pointer grep is now zero. Wave 3 of 3: guardrails, playbooks, powershell-format, prototype, repo-hygiene, review, ruff-format, songwriting, tdd, testing, toolchain, verification, work-items. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 2m 45s —— View job PR Review
SummaryThe core change is correct and complete: all 13 READMEs drop the unreachable repo-root LICENSE pointer, the repo-wide grep ( However, there is one encoding bug introduced in the two more-complex changelogs that needs a fix before merge. Issue: Em-dash mojibake in
|
| File | Proper em dashes on main |
Proper em dashes on this branch |
|---|---|---|
plugins/toolchain/CHANGELOG.md |
9 | 0 |
plugins/verification/CHANGELOG.md |
8 | 0 |
The corruption affects every existing changelog entry in both files (everything from ## [0.5.0] downward in toolchain, and ## [0.3.0] downward in verification). The new ## [0.5.1] / ## [0.3.1] entries themselves are fine because they contain no em dashes.
Example corrupted line in the diff:
- by each lifecycle plugin's own setup — `/discovery:setup`, `/planning:setup`, and the new
+ by each lifecycle plugin's own setup â€" `/discovery:setup`, `/planning:setup`, and the newAffected permalinks:
Fix: Replace the mojibake sequences with proper em dashes in both files. The simplest approach is to sed or programmatically substitute the garbled bytes back to — while leaving everything else untouched, then re-commit. Fix this →
Everything else looks good
- READMEs (13/13): LICENSE pointer correctly removed. Replacement line (
MIT (SPDX-License-Identifier: MIT).) is uniform. Songwriting's Pat Pattison attribution sentence is correctly preserved on the same line. plugin.jsonversions (13/13): All patch bumps are correct and match the top CHANGELOG entry in each file.- CHANGELOG entries (11 simple plugins): Identical, accurate documentation-only description;
## [x.y.z]/### Changed/ bullet matches the exact README edit. - Toolchain / verification new entries (
## [0.5.1]/## [0.3.1]): Content is correct; no em dashes present so those blocks are unaffected by the encoding bug. - Version stacking: Guardrails
0.9.2→0.9.3, work-items0.17.1→0.17.2, toolchain0.5.0→0.5.1, verification0.3.0→0.3.1all align with the PR description's stacking explanation.
|
Claude finished @kyle-sexton's task in 1m 10s —— View job Security Review — PR #771
No security issues found. This PR is documentation-only across all 39 changed files. A full read of the diff confirms: plugin.json (13 files): The only field changed in every manifest is README.md (13 files): The License section drops the dead cross-repo path pointer ( CHANGELOG.md (13 files): Adds a changelog entry describing the documentation change. The toolchain and verification changelogs also reflow encoding of em-dashes that was incidental to the rebase — cosmetic only, no behavior change. There are no GitHub Actions workflow changes, no dependency pin changes, no credential or secret handling, no command execution surfaces, and no path traversal risk introduced. The PR is safe to merge from a security standpoint. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e73433e9d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The conflict-resolution rebuild of the toolchain and verification changelogs decoded git output with the platform legacy codepage and re-encoded as UTF-8, mojibaking em dashes and comparison glyphs across prior entries. Rebuild byte-for-byte from main with the new entry spliced in as bytes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 56s —— View job Security Review — PR #771
No security issues found. This PR is documentation-only across all 39 changed files. Full diff inspection confirms:
There are no GitHub Actions workflow changes, no dependency pin changes, no credential or secret handling, no command execution surfaces, no path traversal risk, and no supply-chain risk introduced. Safe to merge from a security standpoint. |
|
Claude finished @kyle-sexton's task in 2m 8s —— View job PR Review — Encoding Fix Verified ✓
SummaryThe encoding fix in What the fix does: The conflict-resolution rebuild of both changelogs had decoded git output using a legacy codepage and re-encoded as UTF-8, corrupting every em dash ( Verification:
Overall PR status: All issues from the prior review are resolved. The PR is clean:
Ready to merge. |
Closes #537 — final wave; repo-wide repro grep (
at the root of|root of (the )?melodic) returns zero across allplugins/*/README.mdon this branch.Supersedes #766 (identical change, rebased): #737 landed toolchain 0.5.0 / verification 0.3.0 mid-grace, so those two stack as 0.5.1 / 0.3.1; guardrails (0.9.2→0.9.3) and work-items (0.17.1→0.17.2) stack above their own mid-flight entries as before. All 13 manifests match their CHANGELOG top entry; songwriting's methodology-attribution note preserved.
Related
🤖 Generated with Claude Code