Skip to content

docs(adr): renumber the skill interop ADR from 0042 to 0043 - #5591

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/adr-0042-duplicate
Sep 30, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
fix/adr-0042-duplicate

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

No related issue: two concurrent merges (#5512, #5558) both took ADR 0042 and broke check-adr-numbers on main

Summary

docs/adr/ held two records numbered 0042: the config-cascade outlier ratification (#5558, merged 01:59 EDT) and the skill interop decisions (#5512, merged 02:11 EDT). scripts/check-adr-numbers.sh --check runs in the lint-2 job inside ci-status, so every open pull request (for example #5288) failed. This renumbers the later record to 0043.

Fix

  • git mv docs/adr/0042-record-the-skill-interop-decisions-and-conformance-gates.md to docs/adr/0043-record-the-skill-interop-decisions-and-conformance-gates.md. The file states no number in its title or body, so its content is unchanged.
  • Update the two [ADR 0042](...) links in docs/specs/agent-doc-surfaces.md (lines 65 and 96) to [ADR 0043](...) with the new filename.
  • 0042 stays with the config-cascade record, which docs/conventions/config-cascade/ cites about 12 times. The baseline file is untouched: the gate exempts only pairs that merged before it existed.
  • 0043 is free on main and no open pull request adds a docs/adr/0043- file (checked with gh pr list --state open --json number,files).

Verification

  • scripts/check-adr-numbers.sh --check exits 1 on origin/main and 0 on this branch.
  • scripts/validate-plugins.sh passes for every plugin manifest and the catalog.
  • scripts/check-docs-naming.sh --check passes.
  • lychee --offline on docs/specs/agent-doc-surfaces.md reports 0 errors; markdownlint-cli2 on both touched files reports 0 issues.
  • git grep finds no remaining reference to the old filename.

Related

🤖 Generated with Claude Code

PRs #5512 and #5558 merged 12 minutes apart, each taking 0042, so
scripts/check-adr-numbers.sh --check failed on every pull request. Keep 0042 for the
config-cascade record (PR #5558, merged first, cited across
docs/conventions/config-cascade/) and move the interop record to the next free number.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review September 30, 2026 13:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T13:23:59.959768Z ad44a17 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 21s —— View job


Security review

No security issues found.

This PR is a documentation-only change: it renames docs/adr/0042-record-the-skill-interop-decisions-and-conformance-gates.md to docs/adr/0043-record-the-skill-interop-decisions-and-conformance-gates.md (pure rename, file content unchanged) and updates two [ADR 0042](...) links in docs/specs/agent-doc-surfaces.md to point at the new 0043 filename.

Per the skip gate in /review:security-review, this change has no security-relevant surface: no code, no auth/access-control logic, no injection surface, no secrets handling, and no GitHub Actions workflow changes. It also doesn't touch any standing instruction file (CLAUDE.md, AGENTS.md, rules, skill/agent bodies) — the two touched files are an ADR record and a spec/reference doc, and the edits only fix a link target, they don't remove or soften any guardrail.

Review stops here per the skip gate; nothing further to report.

@claude

claude Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 36s —— View job


Claude finished the code-review lane

  • Gather context (PR body, diff, repo instructions)
  • Invoke /review:code-review skill for this PR
  • Post findings (inline comments + summary)

Summary

This PR renumbers docs/adr/0042-record-the-skill-interop-decisions-and-conformance-gates.md to 0043-... and updates the two [ADR 0042] links in docs/specs/agent-doc-surfaces.md (lines 65, 96) to [ADR 0043], resolving a duplicate-number collision between two ADRs both merged as 0042.

Verified independently:

  • git diff origin/main...HEAD shows exactly the rename + two link-text/target updates in docs/specs/agent-doc-surfaces.md; no other changes.
  • git grep -n "0042-record-the-skill-interop" across the tree returns no remaining references to the old filename.
  • docs/adr/ now has 0042-ratify-consumer-config-location-outliers-in-place.md and 0043-record-the-skill-interop-decisions-and-conformance-gates.md — no numbering collision.

This is a mechanical, low-risk documentation fix with no meaningful review surface (skip gate: trivial change). No findings to report.

Note: the PR body's other verification claims (check-adr-numbers.sh, validate-plugins.sh, check-docs-naming.sh, lychee, markdownlint-cli2) are author-claimed and not independently re-run here.

@kyle-sexton
kyle-sexton merged commit 17d0bc6 into main Sep 30, 2026
19 of 27 checks passed
@kyle-sexton
kyle-sexton deleted the fix/adr-0042-duplicate branch September 30, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant