fix(education): correct changelog entries and restore teach action hint - #5243
Conversation
…teach action hint Reword the 0.11.6 entry to say only that the examples moved into the skill body, link the 0.11.3 issue reference, and list the action set in the teach argument-hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EugXnFddtpHcY5gTuyEirB
…orrections Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EugXnFddtpHcY5gTuyEirB
…ash in setup eval Case 9 listed no files, so the sandbox had no change to quiz on. It now lists an auth-middleware diff fixture with a public-path guard, a rate-limit-before-auth ordering, and an invalid-token failure path. The setup case 3 prompt loses its escaped em dash. Extends the 0.11.7 entry. Refs #3589 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EugXnFddtpHcY5gTuyEirB
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 31s —— View job Security review complete ✅
No security issues found. This PR is documentation/metadata only: a Two points I specifically checked and ruled out:
|
|
Claude finished @kyle-sexton's task in 1m 41s —— View job Claude finished the code-review lane
SummaryReviewed all 6 changed files against
No high-signal correctness or maintainability issues found on the changed lines, so no inline comments were posted. Note on verification: this sandbox's permission mode denied |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 467b7ab20c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude finished @kyle-sexton's task in 33s —— View job Code review lane — skipped (already reviewed)
Per the For completeness, note that
These are genuine, verifiable defects (I confirmed the header/line-count mismatch and the trailing-colon parse by reading the files directly) worth fixing before merge, but I'm surfacing rather than re-reporting them as this lane's own findings since they're already on the PR from Codex and this lane's pass on this head is complete. |
|
Claude finished @kyle-sexton's task in 40s —— View job Security review complete ✅
No security issues found. This PR touches 6 files, all metadata, documentation, and eval-fixture content for the
No CRITICAL / IMPORTANT / SUGGESTION findings. |
…lash command The auth-middleware fixture had unprefixed blank context lines and hunk counts that did not match the hunk bodies, so git apply rejected it as a corrupt patch. The setup eval 3 prompt put a colon directly after the slash-command token, so the command parsed as /education:setup:. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EugXnFddtpHcY5gTuyEirB
|
Claude finished @kyle-sexton's task in 1m 21s —— View job Code review complete ✅
No findings. This lane's prior pass (on Commit
I also re-checked the rest of the diff for anything new:
Not independently verified: I don't have shell permission in this session to run |
|
Claude finished @kyle-sexton's task in 1m 4s —— View job Security review complete ✅
No security issues found. This head (
No other files changed since the prior review at |
A blank context line in a diff is a single space, which the editorconfig trailing-whitespace check rejects. The fixture carries no blank context lines and its hunk headers match their bodies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EugXnFddtpHcY5gTuyEirB
|
Claude finished @kyle-sexton's task in 45s —— View job Security review complete ✅
No security issues found. Reviewed the full diff ( All 6 changed files remain metadata/documentation/eval-fixture content for the
No CRITICAL / IMPORTANT / SUGGESTION findings. |
|
Claude finished @kyle-sexton's task in 1m 44s —— View job Code review complete ✅
No findings. The prior pass on this lane ( The only change since
This resolves both defects Codex flagged on I also re-checked the rest of the diff:
Not independently verified: shell access in this session denied |
|
Claude finished @kyle-sexton's task in 59s —— View job Security review complete ✅
No security issues found. Skip gate applies. HEAD
Codex's two prior findings on this PR (malformed diff-fixture hunk headers, a trailing colon in the No CRITICAL / IMPORTANT / SUGGESTION findings. |
|
Claude finished @kyle-sexton's task in 37s —— View job Code review — skipped (already reviewed)
Per the That prior pass already confirmed:
Both defects Codex flagged on the original head ( |
No related issue: audit finding fix
Summary
Audit finding
plugin-education(changelog-integrity, low): theeducation0.11.6 changelog entry claimed more than the change did, the 0.11.3 entry ended in a bare(#4119)instead of a link, and theteachargument hint had dropped its action list. Ships aseducation0.11.7.Fix
plugins/education/CHANGELOG.md:[0.11.6]now says only that the examples moved into the skill body (the old hint carried only(e.g., ...)examples);[0.11.3]links#4119like 0.11.4 to 0.11.6; new[0.11.7]entry.plugins/education/skills/teach/SKILL.md:argument-hintlists the closed action set from the Action Router table (95 characters, inside the 100-character budget).plugins/education/.claude-plugin/plugin.json: version 0.11.6 to 0.11.7.plugins/education/skills/quiz-me/evals/evals.jsoncase 9 lists a new auth-middleware diff fixture (evals/fixtures/auth-middleware-change/auth-middleware.diff: public-path guard, rate-limit-before-auth ordering, invalid-token 401 path) and names those behaviors in its first expectation, so the sandbox has a change to quiz on (planning request, Eval candidates: behavioral heuristics from the Finding Your Unknowns integration #3589 AC2).plugins/education/skills/setup/evals/evals.jsoncase 3: the escaped em dash in the prompt is replaced by a colon (work-items request, F10 of unit 4070).[0.11.6]reworded to say only that the examples moved into the skill body;[0.11.3]issue reference linked. Both are repeated in the[0.11.7]entry, asscripts/check-changelog-parity.shrequires.Verification
bash scripts/check-changelog-parity.sh --check --check-order: pass.bash scripts/check-changelog-parity.sh --check-bump origin/main: pass.bash scripts/check-changelog-parity.sh --check-preserved origin/main: pass (45 headings compared).bash scripts/validate-plugins.sh: all manifests and the catalog validated.bash scripts/validate-plugin-contracts.test.sh: PASS=92 FAIL=0, zero argument-hint warnings in the shipping tree.educationhas no test scripts of its own.Related
.work/audit/REPORT.md, findingplugin-education.plugins/skill-quality/scripts/check-evals-quality.shpasses on each, and the changelog parity checks pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01EugXnFddtpHcY5gTuyEirB