fix(source-control): stop branch-issue resolution on an unusable layer (#4673) - #4760
Merged
Merged
Conversation
#4673) A layer whose ## branch_issue_pattern section exists but yields no usable pattern now stops resolution (no stdout, exit 1, note containing 'resolution stopped') instead of falling through to a lower layer, the userConfig, or the default, any of which could put the wrong number on a Closes #N line. A malformed userConfig value is still ignored. Declares the fail-closed stop as a config-cascade deviation from the degrade-soft rule. source-control 0.61.5 -> 0.62.0. Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
Contributor
|
PR body contract — issue linkage This PR body conforms to the issue-linkage contract. Nothing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4673
Summary
Decision: stop (fail closed). A layer whose
## branch_issue_patternexists but yields no usable pattern stops resolution (no stdout, exit 1, “resolution stopped”) instead of falling through to a wrongCloses #N. Declared exception to config-cascade soft-degrade. Empty sections also stop.source-control→ 0.62.0.Fix
parse-branch-issue.sh+ tests (64/0); docs that said “skipped”; config-cascade Declared entry.Verification
Related