fix(review): report identical-sides assertions unless cant-fail-scan present (#4266) - #4624
Merged
cursor[bot] merged 1 commit intoSep 27, 2026
Conversation
Contributor
|
PR body contract — issue linkage This PR body does not yet satisfy the issue-linkage contract:
Edit the body and this comment updates itself on the next run. |
…output is present code-reviewer deferred the textually-identical-sides core to testing:audit's cant-fail-scan.sh unconditionally, so a repo without the testing plugin, or a review where the audit was not run, had nobody reporting the most blatant tautological assertion. The deferral now requires the scan's output in context; otherwise the reviewer reports the finding and notes the scan did not run. Fixes #4266 Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/code-reviewer-identical-sides-presence-37e9
branch
from
September 27, 2026 20:37
d53eb9a to
97e6ab2
Compare
cursor
Bot
deleted the
cursor/code-reviewer-identical-sides-presence-37e9
branch
September 27, 2026 20:43
2 tasks done
cursor Bot
pushed a commit
that referenced
this pull request
Sep 27, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Fixes #4267 ## Summary Takes the fix the issue favours: flip the confidence rank order instead of banning `low`. - `plugins/review/context/severity.md` ranks `high` > `medium` > `low` > `unscored` and labels every finding with the value its evidence supports. - `code-reviewer` keeps a `Confidence:` value even when the caller supplies its own finding shape. - Detector-findings convention rule 2 unchanged (`high` or omitted); rationale rewritten. `mutation-testing` 0.4.2 drops the false clause. New fanout eval 39 covers unscored sorting last. `review` 0.30.6 → 0.31.0. ## Research trail - `severity.md` owned the inverted order; fanout/fix-pass defer to it. - Detector producers cite the unchanged rule, not the order. ## Test plan - [x] validate-plugins, changed-skills, changelog parity, detector-findings crosswalk - [x] `standards-binding.test.sh` PASS=8; markdownlint clean ## Notes Serialized behind #4624. Open PRs #4622 and #4590 also bump `review` (version-line only). <!-- CURSOR_AGENT_PR_BODY_END --> <div><a href="https://cursor.com/agents/bc-ab53da24-b89d-4314-a060-0da474e837e9?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-ab53da24-b89d-4314-a060-0da474e837e9&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kyle Sexton <kyle-sexton@users.noreply.github.com>
![https://cursor.com/assets/images/open-in-web-dark.png"><source](https://cursor.com/assets/images/open-in-web-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-web-light.png"><img](https://cursor.com/assets/images/open-in-web-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a](https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"><source](https://cursor.com/assets/images/open-in-cursor-dark.png"><source){kind=link}
![https://cursor.com/assets/images/open-in-cursor-light.png"><img](https://cursor.com/assets/images/open-in-cursor-light.png"><img){kind=link}
![https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div](https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4266
Summary
review:code-reviewerdeferred identical-sides assertions totesting:auditunconditionally. Deferral now requires the scan's output in context; otherwise the reviewer reports the finding and notes the scan did not run.Research trail
plugins/testing/skills/audit/scripts/cant-fail-scan.shdocs/conventions/detector-findings/README.md.claude/rules/skill-bodies-state-current-rules.mdTest plan