docs(upstream): record that a user mod loads in Claude Desktop's Code tab - #4290
Conversation
… tab The Desktop probe ADR 0035 and experiments.md left open has been run. On 2026-09-19, Windows 11, Desktop build app-2.2553.1 (bundled Claude Code 2.1.275), a user-authored mod installed at user scope fired its session.start hook in a local Code tab session with CLAUDE_CODE_ENABLE_FUNCTION_HOOKS=1 supplied to the app process only. Record the result, the route that worked, the absent gear icon in that build, and the arms that stay untested: the flag unset in Desktop, cloud sessions, Cowork, and mods that draw UI. The Defer verdict and the five go criteria are unchanged; Desktop loading is in no criterion. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LZaei9mJtbHVmC7kqnsayX
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 2m 56s —— View job Code review complete
Skip gate: none applied — PR is open (not draft, since this lane only runs on non-draft PRs per this repo's Scope: docs-only change ( What I checked:
No correctness or maintainability issues found that clear the high-signal bar (a careful reviewer would not block on anything here). No inline comments posted. Note on the PR's own Verification section: I did not re-run |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 080346000d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
…ing shell $env:CLAUDE_CODE_ENABLE_FUNCTION_HOOKS = '1' sets no user or system variable, but it persists in the PowerShell session that made it and is inherited by everything else launched from that shell. Say so, and give the clear command. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LZaei9mJtbHVmC7kqnsayX
No related issue: the Desktop probe was left as an open manual step inside PR #4241's own committed trail, and this PR records the maintainer's result in that same trail. No tracker item was ever filed for it.
Summary
PR #4241 deferred adopting Claude Code "mods" and listed "does Desktop's Code tab load a user-authored mod?" as an open probe with a by-hand procedure. The maintainer has now run it. Without this, the next reader of ADR 0035 reasons from a stale unknown and repeats a finished experiment.
Fix
docs/upstream/claude-code-mods/experiments.md— the Desktop probe section now opens with the dated result (OBSERVED: a user-authored mod loads in Desktop's Code tab) rather than "Unanswered", records Desktop buildapp-2.2553.1and its bundled Claude Code 2.1.275 against 2.1.278 onPATH, and lists the untested arms. Step 3 gains route (c), the route that actually worked: the fully quit app launched from PowerShell with the enable flag set for that process only, resting on the documented Windows rule that the app inherits user and system environment variables. Route (a), the local environment editor's gear icon, is marked absent in that build. The negative-reading paragraph now names where the bundled version is read.INFERRED, notOBSERVED: the flag-unset arm was never run in Desktop, so the probe cannot separate "the variable reached the bundled process" from "the rollout gate is already on in that build". Still open: that unset arm, cloud sessions, Cowork, and mods that draw UI.docs/adr/0035-defer-claude-code-mods-with-five-go-criteria.md— the "two probes are open" bullet becomes one open (rollout switch) and one partly answered, with the observed result and what remains. The Defer verdict and the five go criteria do not change; Desktop loading is in no criterion. Note that go-no-go.md's after-run rule says a runbook run does not amend an accepted ADR by itself; this is not a runbook run but a correction of a factual open-unknown statement, made at the owner's direction, and it leaves the decision untouched.docs/upstream/claude-code-mods/go-no-go.md— that file never named Desktop, so its only inaccurate line was the pointer calling experiments.md's manual probes wholly open. It now states the observed result and that the other arms stay untested.docs/upstream/claude-code-mods/sources.md— thecode.claude.com/docs/en/desktoprow gains the Windows environment-inheritance sentence the route relies on, and experiments.md in its used-by column, per the runbook's own after-run rule.docs/upstream/claude-code-mods/research-2026-09-19/is frozen and untouched.docs/plugin-philosophy.mdis untouched: its mods row makes no Desktop claim.Verification
node_modules/.bin/markdownlint-cli2on all four touched files: 0 issues.scripts/check-docs-naming.sh --check: every tracked file underdocs/is lower-kebab-case.../upstream/claude-code-mods/experiments.mdfromdocs/adr/.%APPDATA%placeholder.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01LZaei9mJtbHVmC7kqnsayX